From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: Omar Sandoval <osandov@fb.com>,
Paolo Valente <paolo.valente@linaro.org>,
linux-block@vger.kernel.org
Subject: Re: [PATCH 05/10] blk-mq: simplify blk_mq_free_request
Date: Sun, 18 Jun 2017 09:05:41 -0600 [thread overview]
Message-ID: <c632d273-e363-d83d-7f3b-5dea0efd3d47@kernel.dk> (raw)
In-Reply-To: <20170618072406.GA25582@lst.de>
On 06/18/2017 01:24 AM, Christoph Hellwig wrote:
> On Sat, Jun 17, 2017 at 03:50:40PM -0600, Jens Axboe wrote:
>> On 06/16/2017 10:15 AM, Christoph Hellwig wrote:
>>> Merge three functions only tail-called by blk_mq_free_request into
>>> blk_mq_free_request.
>>
>> This doesn't compile, as blk_mq_merge_queue_io() has a call to
>> __blk_mq_finish_request().
>
> Hmm. The tree I've based my work on certainly doesn't. But it doesn't
> even have blk_mq_merge_queue_io at all either, as does your for-4.13/block
> block tree.
>
> What am I missing?
I tossed it into master for testing by mistake. It's fine against
for-4.13/block, my fault.
I ran it through the regular testing and no issues uncovered so far.
--
Jens Axboe
next prev parent reply other threads:[~2017-06-18 15:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 16:15 streamline blk-mq I/O scheduler interaction Christoph Hellwig
2017-06-16 16:15 ` [PATCH 01/10] blk-mq: mark blk_mq_rq_ctx_init static Christoph Hellwig
2017-06-16 16:15 ` [PATCH 02/10] blk-mq: move blk_mq_sched_{get,put}_request to blk-mq.c Christoph Hellwig
2017-06-16 16:15 ` [PATCH 03/10] blk-mq: remove blk_mq_sched_{get,put}_rq_priv Christoph Hellwig
2017-06-16 16:15 ` [PATCH 04/10] blk-mq-sched: unify request finished methods Christoph Hellwig
2017-06-19 13:01 ` Paolo Valente
2017-06-16 16:15 ` [PATCH 05/10] blk-mq: simplify blk_mq_free_request Christoph Hellwig
2017-06-17 21:50 ` Jens Axboe
2017-06-18 7:24 ` Christoph Hellwig
2017-06-18 15:05 ` Jens Axboe [this message]
2017-06-16 16:15 ` [PATCH 06/10] blk-mq: streamline blk_mq_get_request Christoph Hellwig
2017-06-16 16:15 ` [PATCH 07/10] bfq-iosched: fix NULL ioc check in bfq_get_rq_private Christoph Hellwig
2017-06-19 13:14 ` Paolo Valente
2017-06-16 16:15 ` [PATCH 08/10] blk-mq: refactor blk_mq_sched_assign_ioc Christoph Hellwig
2017-06-16 16:15 ` [PATCH 09/10] blk-mq-sched: unify request prepare methods Christoph Hellwig
2017-06-19 13:32 ` Paolo Valente
2017-06-20 9:10 ` Christoph Hellwig
2017-06-16 16:15 ` [PATCH 10/10] blk-mq: remove __blk_mq_alloc_request Christoph Hellwig
2017-06-16 20:30 ` streamline blk-mq I/O scheduler interaction Jens Axboe
2017-06-18 18:35 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c632d273-e363-d83d-7f3b-5dea0efd3d47@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
--cc=paolo.valente@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox