From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relayaws-01.paragon-software.com (relayaws-01.paragon-software.com [35.157.23.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0853B39EF3B; Wed, 4 Mar 2026 09:58:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=35.157.23.187 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772618287; cv=none; b=r5wHRtbUbpvyk40DbV60NJ2S//6JqmV70J1x3F9VNb9cjg1JKTKySkBvxb5vzReEvA6aHzKiUJW9u32OJqgI92rqMB7Y2RL9QkBMB8QUoRi2XjIvqQQJgXQU7jDuGfrSf5FUKKo6HJVNQi1/NVhL4+uRLllxGbP9VZaB4m8tLtA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772618287; c=relaxed/simple; bh=fI+vexsTPJVCqZpKkMJGR83uuJfFm+zjxRoLgV/4HRo=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=dAveup5w0P3C2luG7gwGwot8nbua4wSfQDiBFEIzAGWmJ9GaGmcPy4/p/beFaGOs0wNIrffSOzRL2zO2Y0qcGyA3NxTGdMNunpB9prBlKinz6ydVT33Vlt44NV6cqWRaWCjSJpNcUgZiqAHSryfzPs6NSCNzHFoMxc1LJ2VBL3Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=paragon-software.com; spf=pass smtp.mailfrom=paragon-software.com; dkim=pass (1024-bit key) header.d=paragon-software.com header.i=@paragon-software.com header.b=L/5hpOlo; arc=none smtp.client-ip=35.157.23.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=paragon-software.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paragon-software.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=paragon-software.com header.i=@paragon-software.com header.b="L/5hpOlo" Received: from relayfre-01.paragon-software.com (unknown [176.12.100.13]) by relayaws-01.paragon-software.com (Postfix) with ESMTPS id 1E8BA1D40; Wed, 4 Mar 2026 09:56:24 +0000 (UTC) Authentication-Results: relayaws-01.paragon-software.com; dkim=pass (1024-bit key; unprotected) header.d=paragon-software.com header.i=@paragon-software.com header.b=L/5hpOlo; dkim-atps=neutral Received: from dlg2.mail.paragon-software.com (vdlg-exch-02.paragon-software.com [172.30.1.105]) by relayfre-01.paragon-software.com (Postfix) with ESMTPS id 11067455; Wed, 4 Mar 2026 09:58:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paragon-software.com; s=mail; t=1772618283; bh=rLSjnmY/cT6MyNJrkorgVkW/EiWZZxD40n/yPLgNYgA=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=L/5hpOlo2ThTyN5JgtP+XTVcc/qsumK9z6Pi3+yyFWzq2fvgmTcJnyfSjI8HS/ecR 8oIsYSLE+dU3kwYhKA90eNkcp8/rhILO0FzNH8jT2z27+F/WcZe6LRWs+iPgy/q6sW 086dqkk8pB162t3OmbwM353L7I0Tpm3D3bPyadUo= Received: from [192.168.95.128] (172.30.20.150) by vdlg-exch-02.paragon-software.com (172.30.1.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Wed, 4 Mar 2026 12:58:01 +0300 Message-ID: Date: Wed, 4 Mar 2026 10:57:59 +0100 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 12/16] ntfs3: remove copy and pasted iomap code To: Christoph Hellwig CC: Jens Axboe , Christian Brauner , "Darrick J. Wong" , Carlos Maiolino , "Martin K. Petersen" , Anuj Gupta , Kanchan Joshi , , , , , References: <20260223132021.292832-1-hch@lst.de> <20260223132021.292832-13-hch@lst.de> <449fd474-0b61-42ff-afbe-56b728d69262@paragon-software.com> <20260303152141.GB5281@lst.de> Content-Language: en-US From: Konstantin Komarov In-Reply-To: <20260303152141.GB5281@lst.de> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: vdlg-exch-02.paragon-software.com (172.30.1.105) To vdlg-exch-02.paragon-software.com (172.30.1.105) On 3/3/26 16:21, Christoph Hellwig wrote: > On Fri, Feb 27, 2026 at 02:46:08PM +0100, Konstantin Komarov wrote: >> Thanks for the note. The iomap helper was copied because >> `iomap_bio_read_folio_range` is defined `static` in iomap/bio.c and thus >> not available for reuse; that prevented using the exported helpers in this >> tree. > Please talk to maintainers and authors before copy and pasting their > code. There's usually a better way. > Understood. In future I will contact the authors and maintainers before copying code. Regards, Konstantin