From: "jianchao.wang" <jianchao.w.wang@oracle.com>
To: Bart Van Assche <bart.vanassche@wdc.com>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Ming Lei <ming.lei@redhat.com>,
Alan Stern <stern@rowland.harvard.edu>,
Johannes Thumshirn <jthumshirn@suse.de>
Subject: Re: [PATCH v4 07/10] block, scsi: Rework runtime power management
Date: Mon, 6 Aug 2018 10:46:38 +0800 [thread overview]
Message-ID: <c92dffc6-c7e6-c040-00db-6f42e51618fb@oracle.com> (raw)
In-Reply-To: <20180804000325.3610-8-bart.vanassche@wdc.com>
Hi Bart
On 08/04/2018 08:03 AM, Bart Van Assche wrote:
> Instead of allowing requests that are not power management requests
> to enter the queue in runtime suspended status (RPM_SUSPENDED), make
> the blk_get_request() caller block.
Who will resume the runtime suspended device ?
In original blk-legacy, when a request is added, blk_pm_add_request will call
pm_request_resume could do that. The request will be issued after the q is resumed
successfully.
After this patch, non-pm request will be blocked and pm_request_resume is removed from
blk_pm_add_request, who does resume the runtime suspended q and device ?
Thanks
Jianchao
next prev parent reply other threads:[~2018-08-06 2:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-04 0:03 [PATCH v4 00/10] blk-mq: Enable runtime power management Bart Van Assche
2018-08-04 0:03 ` [PATCH v4 01/10] block: Change the preempt-only flag into a counter Bart Van Assche
2018-08-06 6:25 ` Hannes Reinecke
2018-09-14 12:53 ` Christoph Hellwig
2018-08-04 0:03 ` [PATCH v4 02/10] block, scsi: Give RQF_PREEMPT back its original meaning Bart Van Assche
2018-08-04 1:16 ` Ming Lei
2018-08-06 14:15 ` Bart Van Assche
2018-08-06 6:27 ` Hannes Reinecke
2018-08-06 13:54 ` Bart Van Assche
2018-09-14 12:58 ` hch
2018-08-04 0:03 ` [PATCH v4 03/10] block, ide: Remove flag BLK_MQ_REQ_PREEMPT Bart Van Assche
2018-08-04 0:03 ` [PATCH v4 04/10] block: Move power management code into a new source file Bart Van Assche
2018-09-14 13:01 ` Christoph Hellwig
2018-09-14 14:10 ` Alan Stern
2018-08-04 0:03 ` [PATCH v4 05/10] block: Serialize queue freezing and blk_pre_runtime_suspend() Bart Van Assche
2018-08-04 10:23 ` Ming Lei
2018-08-06 14:19 ` Bart Van Assche
2018-08-04 0:03 ` [PATCH v4 06/10] percpu-refcount: Introduce percpu_ref_read() Bart Van Assche
2018-08-04 0:03 ` [PATCH v4 07/10] block, scsi: Rework runtime power management Bart Van Assche
2018-08-04 10:01 ` Ming Lei
2018-08-06 15:20 ` Bart Van Assche
2018-08-06 22:30 ` Ming Lei
2018-08-06 2:46 ` jianchao.wang [this message]
2018-08-06 15:07 ` Bart Van Assche
2018-08-04 0:03 ` [PATCH v4 08/10] block: Remove blk_pm_requeue_request() Bart Van Assche
2018-08-04 0:03 ` [PATCH v4 09/10] blk-mq: Insert blk_pm_{add,put}_request() calls Bart Van Assche
2018-08-04 0:03 ` [PATCH v4 10/10] blk-mq: Enable support for runtime power management Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c92dffc6-c7e6-c040-00db-6f42e51618fb@oracle.com \
--to=jianchao.w.wang@oracle.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).