From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: To: Dan Williams Cc: Bjorn Helgaas , Linux Kernel Mailing List , linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma , linux-nvdimm , linux-block@vger.kernel.org, Stephen Bates , Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg , Bjorn Helgaas , Jason Gunthorpe , Max Gurtovoy , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Benjamin Herrenschmidt , Alex Williamson References: <20180228234006.21093-1-logang@deltatee.com> <20180228234006.21093-3-logang@deltatee.com> <20180301174450.GF13722@bhelgaas-glaptop.roam.corp.google.com> From: Logan Gunthorpe Message-ID: Date: Thu, 1 Mar 2018 17:37:58 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Subject: Re: [PATCH v2 02/10] PCI/P2PDMA: Add sysfs group to display p2pmem stats List-ID: On 01/03/18 05:36 PM, Dan Williams wrote: > On Thu, Mar 1, 2018 at 4:15 PM, Logan Gunthorpe wrote: >> >> >> On 01/03/18 10:44 AM, Bjorn Helgaas wrote: >>> >>> I think these two statements are out of order, since the attributes >>> dereference pdev->p2pdma. And it looks like you set "error" >>> unnecessarily, since you return immediately looking at it. >> >> >> Per the previous series, sysfs_create_group is must_check for some reason. I >> had a printk there but you didn't think it was necessary. So assigning it to >> error is the only way to squash the warning. > > Why not fail the setup if the sysfs_create_group() fails? Sure, it may > not be strictly required for userspace to have access to these > attributes, but it seems hostile that userspace can't make assumptions > about the presence of the "p2pmem" directory relative to the > capability being setup. Works for me. I'll do that. Thanks, Logan