From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>, Ning Li <lining2020x@163.com>,
Tejun Heo <tj@kernel.org>, Chunguang Xu <brookxu@tencent.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V4 2/8] block: move blk_crypto_bio_prep() out of blk-mq.c
Date: Wed, 16 Feb 2022 09:15:49 +0000 [thread overview]
Message-ID: <c990b091-e1cb-7521-e0d9-7e3e3dd8ad6f@nvidia.com> (raw)
In-Reply-To: <20220216044514.2903784-3-ming.lei@redhat.com>
On 2/15/22 20:45, Ming Lei wrote:
> blk_crypto_bio_prep() is called for both bio based and blk-mq drivers,
> so move it out of blk-mq.c, then we can unify this kind of handling.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
> block/blk-core.c | 21 ++++++++-------------
indeed it is, looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
next prev parent reply other threads:[~2022-02-16 9:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 4:45 [PATCH V4 0/8] block: improve iops limit throttle Ming Lei
2022-02-16 4:45 ` [PATCH V4 1/8] block: move submit_bio_checks() into submit_bio_noacct Ming Lei
2022-02-16 9:14 ` Chaitanya Kulkarni
2022-02-16 4:45 ` [PATCH V4 2/8] block: move blk_crypto_bio_prep() out of blk-mq.c Ming Lei
2022-02-16 9:15 ` Chaitanya Kulkarni [this message]
2022-02-16 4:45 ` [PATCH V4 3/8] block: don't declare submit_bio_checks in local header Ming Lei
2022-02-16 9:16 ` Chaitanya Kulkarni
2022-02-16 4:45 ` [PATCH V4 4/8] block: don't check bio in blk_throtl_dispatch_work_fn Ming Lei
2022-02-16 7:36 ` Christoph Hellwig
2022-02-16 4:45 ` [PATCH V4 5/8] block: merge submit_bio_checks() into submit_bio_noacct Ming Lei
2022-02-16 9:17 ` Chaitanya Kulkarni
2022-02-16 4:45 ` [PATCH V4 6/8] block: throttle split bio in case of iops limit Ming Lei
2022-02-16 4:45 ` [PATCH V4 7/8] block: don't try to throttle split bio if iops limit isn't set Ming Lei
2022-02-16 4:45 ` [PATCH V4 8/8] block: revert 4f1e9630afe6 ("blk-throtl: optimize IOPS throttle for large IO scenarios") Ming Lei
2022-02-17 2:42 ` [PATCH V4 0/8] block: improve iops limit throttle Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c990b091-e1cb-7521-e0d9-7e3e3dd8ad6f@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=brookxu@tencent.com \
--cc=hch@lst.de \
--cc=lining2020x@163.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox