From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH] block: cleanup the VM accounting in submit_bio
Date: Mon, 16 May 2022 11:37:08 -0600 [thread overview]
Message-ID: <c9c389a0-650f-aea4-fe87-c5ebccc7129c@kernel.dk> (raw)
In-Reply-To: <20220516141141.GA11736@lst.de>
On 5/16/22 8:11 AM, Christoph Hellwig wrote:
> On Mon, May 16, 2022 at 03:45:08PM +0200, Damien Le Moal wrote:
>> I know it is the same value, but for consistency, wouldn't it be better to use
>> REQ_OP_WRITE here ?
>
> Yes, it absolutely would. The use of WRITE wasn't even initentional.
I'll fix it up.
--
Jens Axboe
prev parent reply other threads:[~2022-05-16 17:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 6:36 [PATCH] block: cleanup the VM accounting in submit_bio Christoph Hellwig
2022-05-16 12:38 ` Jens Axboe
2022-05-16 13:45 ` Damien Le Moal
2022-05-16 14:11 ` Christoph Hellwig
2022-05-16 17:37 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9c389a0-650f-aea4-fe87-c5ebccc7129c@kernel.dk \
--to=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox