From: Jens Axboe <axboe@kernel.dk>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Christoph Hellwig <hch@lst.de>,
linux-block <linux-block@vger.kernel.org>
Subject: Re: [PATCH] block: genhd: don't call blkdev_show() with major_names_lock held
Date: Tue, 7 Sep 2021 11:16:43 -0600 [thread overview]
Message-ID: <c9f4f443-4aac-6ffb-530a-7cb687c54305@kernel.dk> (raw)
In-Reply-To: <0123937a-2e94-a1f8-110a-ecd0d3d7f0c6@i-love.sakura.ne.jp>
On 9/7/21 8:42 AM, Tetsuo Handa wrote:
> On 2021/09/07 23:36, Jens Axboe wrote:
>> On 9/7/21 5:52 AM, Tetsuo Handa wrote:
>>> The simplest fix is to call probe function without holding
>>> major_names_lock [1], but Christoph Hellwig does not like such idea.
>>> Therefore, instead of holding major_names_lock in blkdev_show(),
>>> introduce a different lock for blkdev_show() in order to break
>>> "sb_writers#$N => &p->lock => major_names_lock" dependency chain.
>>
>> Agree, that's probably the easiest fix here. Applied, thanks.
>>
>
> Sorry, can you update the patch title to:
>
> block: genhd: don't hold major_names_lock in blkdev_show()
I already have a number of patches (and a pull) sitting on top
of it...
--
Jens Axboe
prev parent reply other threads:[~2021-09-07 17:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 11:52 [PATCH] block: genhd: don't call blkdev_show() with major_names_lock held Tetsuo Handa
2021-09-07 14:36 ` Jens Axboe
2021-09-07 14:42 ` Tetsuo Handa
2021-09-07 17:16 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9f4f443-4aac-6ffb-530a-7cb687c54305@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox