Re: [PATCH V5 2/7] ublk_drv: define macros for recovery feature and check them

Ming Lei
2022-09-23T03:03:42Z

On Thu, Sep 22, 2022 at 02:17:29PM +0800, ZiyangZhang wrote:
> Define some macros for recovery feature.
>
> UBLK_S_DEV_QUIESCED implies that ublk_device is quiesced
> and is ready for recovery. This state can be observed by userspace.
>
> UBLK_F_USER_RECOVERY implies that:
> (1) ublk_drv enables recovery feature. It won't let monitor_work to
> automatically abort rqs and release the device.
> (2) With a dying ubq_daemon, ublk_drv ends(aborts) rqs issued to
> userspace(ublksrv) before crash.
> (3) With a dying ubq_daemon, in task work and ublk_queue_rq(),
> ublk_drv requeues rqs.
>
> Signed-off-by: ZiyangZhang <ZiyangZhang@linux.alibaba.com>

Reviewed-by: Ming Lei <ming.lei@redhat.com>

Thanks,
Ming