From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: John Garry <john.g.garry@oracle.com>,
"axboe@kernel.dk" <axboe@kernel.dk>, hch <hch@lst.de>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Subject: Re: [PATCH RFC 1/6] block: Rework bio_split() return value
Date: Thu, 19 Sep 2024 15:50:08 +0000 [thread overview]
Message-ID: <cbe3c6f0-cc84-4e92-bae4-5433ee0549e2@wdc.com> (raw)
In-Reply-To: <20240919092302.3094725-2-john.g.garry@oracle.com>
On 19.09.24 11:25, John Garry wrote:
> - BUG_ON(sectors <= 0);
> - BUG_ON(sectors >= bio_sectors(bio));
> + if (WARN_ON(sectors <= 0))
> + return ERR_PTR(-EINVAL);
> + if (WARN_ON(sectors >= bio_sectors(bio)))
> + return ERR_PTR(-EINVAL);
Nit: WARN_ON_ONCE() otherwise it'll trigger endless amounts of
stacktraces in dmesg.
next prev parent reply other threads:[~2024-09-19 15:50 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 9:22 [PATCH RFC 0/6] bio_split() error handling rework John Garry
2024-09-19 9:22 ` [PATCH RFC 1/6] block: Rework bio_split() return value John Garry
2024-09-19 15:50 ` Johannes Thumshirn [this message]
2024-09-23 7:27 ` John Garry
2024-09-20 14:07 ` Christoph Hellwig
2024-09-19 9:22 ` [PATCH RFC 2/6] block: Error an attempt to split an atomic write in bio_split() John Garry
2024-09-19 9:22 ` [PATCH RFC 3/6] block: Handle bio_split() errors in bio_submit_split() John Garry
2024-09-20 14:09 ` Christoph Hellwig
2024-09-23 10:33 ` John Garry
2024-09-19 9:23 ` [PATCH RFC 4/6] md/raid0: Handle bio_split() errors John Garry
2024-09-20 14:10 ` Christoph Hellwig
2024-09-19 9:23 ` [PATCH RFC 5/6] md/raid1: " John Garry
2024-09-20 6:58 ` Yu Kuai
2024-09-20 10:04 ` John Garry
2024-09-23 6:15 ` Yu Kuai
2024-09-23 7:44 ` John Garry
2024-09-23 8:18 ` Yu Kuai
2024-09-23 9:21 ` John Garry
2024-09-23 9:38 ` Yu Kuai
2024-09-23 10:40 ` John Garry
2024-10-23 11:16 ` John Garry
2024-10-23 11:46 ` Geoff Back
2024-10-23 12:11 ` John Garry
2024-10-24 2:10 ` Yu Kuai
2024-10-24 8:57 ` John Garry
2024-10-24 9:12 ` Yu Kuai
2024-10-24 9:56 ` John Garry
2024-10-25 1:39 ` Yu Kuai
2024-10-23 11:21 ` John Garry
2024-10-24 3:08 ` Yu Kuai
2024-10-24 13:51 ` John Garry
2024-10-25 1:24 ` Yu Kuai
2024-09-19 9:23 ` [PATCH RFC 6/6] md/raid10: " John Garry
2024-09-23 5:53 ` [PATCH RFC 0/6] bio_split() error handling rework Hannes Reinecke
2024-09-23 7:19 ` John Garry
2024-09-23 9:43 ` Hannes Reinecke
2024-09-23 10:21 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbe3c6f0-cc84-4e92-bae4-5433ee0549e2@wdc.com \
--to=johannes.thumshirn@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox