From: Hannes Reinecke <hare@suse.de>
To: "Markus Blöchl" <Markus.Bloechl@ipetronik.com>,
"Christoph Hellwig" <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, Stefan Roese <sr@denx.de>
Subject: Re: [RFC PATCH] nvme: prevent hang on surprise removal of NVMe disk
Date: Wed, 16 Feb 2022 12:32:37 +0100 [thread overview]
Message-ID: <ccca97fb-0dab-0a8f-d2ac-247ba160288d@suse.de> (raw)
In-Reply-To: <20220216111841.jaunxn6blouzjleg@ipetronik.com>
On 2/16/22 12:18, Markus Blöchl wrote:
> On Tue, Feb 15, 2022 at 08:17:31PM +0100, Christoph Hellwig wrote:
>> On Mon, Feb 14, 2022 at 10:51:07AM +0100, Markus Blöchl wrote:
>>> After the surprise removal of a mounted NVMe disk the pciehp task
>>> reliably hangs forever with a trace similar to this one:
>>
>> Do you have a specific reproducer? At least with doing a
>>
>> echo 1 > /sys/.../remove
>>
>> while running fsx on a file system I can't actually reproduce it.
>
> We built our own enclosures with a custom connector to plug the disks.
>
> So an external enclosure for thunderbolt is probably very similar.
> (or just ripping an unscrewed NVMe out of the M.2 ...)
>
> But as already suggested, qemu might also be very useful here as it also
> allows us to test multiple namespaces and multipath I/O, if you/someone
> wants to check those too (hotplug with multipath I/O really scares me).
>
Nothing to be scared of.
I've tested this extensively in the run up to commit 5396fdac56d8
("nvme: fix refcounting imbalance when all paths are down") which,
incidentally, is something you need if you want to test things.
Let me see if I can dig up the testbed.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
next prev parent reply other threads:[~2022-02-16 11:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 9:51 [RFC PATCH] nvme: prevent hang on surprise removal of NVMe disk Markus Blöchl
2022-02-15 15:22 ` Keith Busch
2022-02-15 18:47 ` Christoph Hellwig
2022-02-15 19:14 ` Keith Busch
2022-02-15 19:17 ` Christoph Hellwig
2022-02-15 19:37 ` Keith Busch
2022-02-16 6:39 ` Hannes Reinecke
2022-02-16 11:18 ` Markus Blöchl
2022-02-16 11:32 ` Hannes Reinecke [this message]
2022-02-15 20:17 ` Christoph Hellwig
2022-02-16 12:59 ` Markus Blöchl
2022-02-16 13:33 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccca97fb-0dab-0a8f-d2ac-247ba160288d@suse.de \
--to=hare@suse.de \
--cc=Markus.Bloechl@ipetronik.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox