Re: [PATCH 2/2] fs: Remove kiocb->ki_complete

kernel test robot
2020-07-09T05:24:33Z

[-- Attachment #1: Type: text/plain, Size: 2510 bytes --]

Hi "Matthew,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on block/for-next]
[cannot apply to balbi-usb/testing/next cifs/for-next miklos-vfs/overlayfs-next linus/master v5.8-rc4 next-20200708]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Matthew-Wilcox-Oracle/Remove-kiocb-ki_complete/20200709-062758
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: s390-randconfig-r013-20200708 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 02946de3802d3bc65bc9f2eb9b8d4969b5a7add8)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install s390 cross compiling tool for clang build
# apt-get install binutils-s390x-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=s390

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

In file included from arch/s390/purgatory/purgatory.c:10:
In file included from include/linux/kexec.h:18:
In file included from include/linux/crash_core.h:6:
In file included from include/linux/elfcore.h:9:
In file included from arch/s390/include/asm/elf.h:132:
In file included from include/linux/compat.h:17:
>> include/linux/fs.h:353:41: warning: shifting a negative signed value is undefined [-Wshift-negative-value]
kiocb->ki_flags = (kiocb->ki_flags & (~IOCB_COMPLETION_FNS)) |
^~~~~~~~~~~~~~~~~~~
include/linux/fs.h:325:33: note: expanded from macro 'IOCB_COMPLETION_FNS'
#define IOCB_COMPLETION_FNS (~0 << _IOCB_COMPLETION_SHIFT)
~~ ^
1 warning generated.

vim +353 include/linux/fs.h

350
351 static inline void kiocb_set_completion(struct kiocb *kiocb, int id)
352 {
> 353 kiocb->ki_flags = (kiocb->ki_flags & (~IOCB_COMPLETION_FNS)) |
354 (id << _IOCB_COMPLETION_SHIFT);
355 }
356

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29080 bytes --]