Re: [PATCH] block: blk-mq.c: fix @at_head kernel-doc warning

Randy Dunlap
2020-08-16T23:40:54Z

On 8/16/20 3:50 PM, André Almeida wrote:
> Hi Randy,
>
> On 8/16/20 7:25 PM, Randy Dunlap wrote:
>> Fix a new kernel-doc warning in block/blk-mq.c:
>>
>> ../block/blk-mq.c:1844: warning: Function parameter or member 'at_head' not described in 'blk_mq_request_bypass_insert'
>>
>> Fixes: 105663f73e71 ("blk-mq: Document functions for sending request")
>
> By the time commit 105663f73e71 ("blk-mq: Document functions for sending
> request") was merged, the parameter @at_head didn't exist[1].
>
> The commit that inserted this warning is 01e99aeca397 ("blk-mq: insert
> passthrough request into hctx->dispatch directly"), that added @at_head
> without updating the documentation.
>
> Thanks,
> André

Hi André,

Sorry, I'll correct that.

thanks.

> [1]
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/block/blk-mq.c?id=105663f73e71b5e79ecf472c0499c9acde654b28#n1673

--
~Randy