From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78F88C001DE for ; Wed, 2 Aug 2023 09:12:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234029AbjHBJMf (ORCPT ); Wed, 2 Aug 2023 05:12:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234003AbjHBJM1 (ORCPT ); Wed, 2 Aug 2023 05:12:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43C1A2D40 for ; Wed, 2 Aug 2023 02:12:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CD099618B3 for ; Wed, 2 Aug 2023 09:12:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7FE5DC433C8; Wed, 2 Aug 2023 09:12:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690967545; bh=MhvlYGmCUTM7OPFqMwovUsxzqD1T7kKin6g29nFETjg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=IQFKDdz+e3x8Rf/0exRqakR4KFmU22xHS7E+T+n3p0u9pK8zK1CvSLNYXAh1MWsDB DPV7ITFRnjdLyNxT40cSUA2RZkW1Xklik7/WKk6RNUWCUu1kAnLsydzVCYVWRsFVov UY26xsQW8eQjY5eFhWpxM9qobWKHmGYA/ZSfJBAVG2ThmyucXOhXahFVnYb9wcMNl+ w7SIEtxww2gBM80YRJO+tLqvMLxbtGM/0Jkh3Ay+4koS6hI8tIOSjIvP8VlC5BfKef 3aJLHWIoJzCLbtImp3GB82xP9R6I3eZno/kTYSbkgQaDYT7G+/9FmrdLppl8RhhFL2 fdPGS0Ylsj4aQ== Message-ID: Date: Wed, 2 Aug 2023 18:12:23 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v5 3/7] scsi: core: Retry unaligned zoned writes Content-Language: en-US To: Bart Van Assche , Jens Axboe Cc: linux-block@vger.kernel.org, Christoph Hellwig , "Martin K . Petersen" , Ming Lei , "James E.J. Bottomley" References: <20230731221458.437440-1-bvanassche@acm.org> <20230731221458.437440-4-bvanassche@acm.org> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20230731221458.437440-4-bvanassche@acm.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 8/1/23 07:14, Bart Van Assche wrote: > If zoned writes (REQ_OP_WRITE) for a sequential write required zone have > a starting LBA that differs from the write pointer, e.g. because zoned > writes have been reordered, then the storage device will respond with an > UNALIGNED WRITE COMMAND error. Send commands that failed with an > unaligned write error to the SCSI error handler if zone write locking is > disabled. Let the SCSI error handler sort SCSI commands per LBA before > resubmitting these. > > If zone write locking is disabled, increase the number of retries for > write commands sent to a sequential zone to the maximum number of > outstanding commands because in the worst case the number of times > reordered zoned writes have to be retried is (number of outstanding > writes per sequential zone) - 1. > > Cc: Martin K. Petersen > Cc: Christoph Hellwig > Cc: Damien Le Moal > Cc: Ming Lei > Signed-off-by: Bart Van Assche Looks OK. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research