Linux block layer
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: shashank Jain <jain.sm@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>,
	Hannes Reinecke <hare@suse.de>,
	Chaitanya Kulkarni <kch@nvidia.com>,
	"Martin K. Petersen" <mkp@kernel.org>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] block: fix the length of a smaller last zone in blkdev_get_zone_info()
Date: Mon, 12 Oct 2026 14:46:21 +0200	[thread overview]
Message-ID: <cfd38ed0-4e3f-4276-97a7-e172922d4ef6@kernel.org> (raw)
In-Reply-To: <CA+FWx=kgeR8tz46tijYE-s=v+PTJjGfM+3ucQOo0ZuDyqFdYQw@mail.gmail.com>

On 2026/10/12 14:41, shashank Jain wrote:
> On Mon, Oct 12, 2026, Damien Le Moal wrote:
>> How do you plan to issue a BLK_ZONE_REP_CACHED report? "blkzone report"
>> does not have that yet. I am planning to send a patch for it.
> 
> Good point. Two options, and I am happy to follow your preference:
> 
> - Use "blkzone report" with the cached flag once your util-linux patch
>   lands - that matches the existing zbd tests and avoids a bundled tool.
>   I would hold the blktests submission until it is available.
> - Or carry a small C helper in the blktests src/ directory that issues
>   BLKREPORTZONEV2 with BLK_ZONE_REP_CACHED directly, so the test is
>   self-contained and does not depend on the util-linux version.
> 
> I lean towards the first, to match the zbd conventions and your blkzone
> work; tell me which you prefer and I will align the test with it.

Yes, let's avoid the small helper. Having access to the cached report with
blkzone will be useful for many things anyway, and the patch should be easy.

-- 
Damien Le Moal
Western Digital Research

      parent reply	other threads:[~2026-10-12 12:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-11  5:19 [PATCH 0/2] block: two fixes for the zone report ioctls Shashank Mohan Jain
2026-10-11  5:19 ` [PATCH 1/2] block: only use the cached zone report if BLK_ZONE_REP_CACHED is set Shashank Mohan Jain
2026-10-11 14:46   ` Damien Le Moal
2026-10-11 15:44     ` shashank Jain
2026-10-12  4:58     ` Shashank Mohan Jain
2026-10-11  5:19 ` [PATCH 2/2] block: fix the length of a smaller last zone in blkdev_get_zone_info() Shashank Mohan Jain
2026-10-11 14:47   ` Damien Le Moal
2026-10-12 12:21   ` Christoph Hellwig
2026-10-12 12:29     ` shashank Jain
2026-10-12 12:37       ` Damien Le Moal
2026-10-12 12:41         ` shashank Jain
2026-10-12 12:45           ` Damien Le Moal
2026-10-12 12:53             ` shashank Jain
2026-10-12 13:04               ` Damien Le Moal
2026-10-12 13:08                 ` shashank Jain
2026-10-12 12:46           ` Damien Le Moal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfd38ed0-4e3f-4276-97a7-e172922d4ef6@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=jain.sm@gmail.com \
    --cc=johannes.thumshirn@wdc.com \
    --cc=kch@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkp@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox