From: Omar Sandoval <osandov@osandov.com>
To: Jens Axboe <axboe@fb.com>, linux-block@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com,
Alexei Starovoitov <ast@fb.com>
Subject: [PATCH v4 0/6] blk-mq: generalization and bug fixes for tag allocation
Date: Sat, 17 Sep 2016 01:28:20 -0700 [thread overview]
Message-ID: <cover.1474100040.git.osandov@fb.com> (raw)
From: Omar Sandoval <osandov@fb.com>
This is v4 of the patch series to turn blk-mq's scalable tag allocation
into a generic library, fixing a few bugs along the way. This is both
cleanup and preparation for coming blk-mq work.
v1 is here [1], v2 is here [2], v3 is here [3].
Changes in v4:
- Added patch 6 to fix a bug in blk-mq where shrinking the tag set
doesn't stop allocations from happening to high tags.
- Changed the interface for raw `sbitmap_get()` to pass the allocation
hint as a value, not a pointer. This pushes the hint updating out into
`sbitmap_queue_get()` where it makes more sense.
Changes in v3:
- Renamed scale_bitmap to sbitmap
Changes in v2:
- Return -EINVAL instead of BUG_ON() if an invalid shift is passed to
the initialization functions.
- Rename last_cache to alloc_hint.
- Split the wait queue allocation change into a separate patch. Patch 1
should now be a no-op.
- Add patches 3 and 4 to make the API cleaner by pushing some context
from the blk-mq data structures into the common scale_bitmap code.
- Add patch 5 to randomize the allocation hint on initialization like
Applies to v4.8-rc6.
Thanks!
1: http://marc.info/?l=linux-block&m=147251402805405&w=2
2: http://marc.info/?l=linux-block&m=147329198222482&w=2
3: http://marc.info/?l=linux-block&m=147344663202718&w=2
Omar Sandoval (6):
blk-mq: abstract tag allocation out into sbitmap library
sbitmap: allocate wait queues on a specific node
sbitmap: push per-cpu last_tag into sbitmap_queue
sbitmap: push alloc policy into sbitmap_queue
sbitmap: randomize initial alloc_hint values
sbitmap: re-initialize allocation hints after resize
MAINTAINERS | 1 +
block/Kconfig | 1 +
block/blk-mq-tag.c | 503 +++++++++++-------------------------------------
block/blk-mq-tag.h | 42 ++--
block/blk-mq.c | 114 ++++-------
block/blk-mq.h | 11 --
include/linux/blk-mq.h | 9 +-
include/linux/sbitmap.h | 373 +++++++++++++++++++++++++++++++++++
lib/Kconfig | 3 +
lib/Makefile | 2 +
lib/sbitmap.c | 347 +++++++++++++++++++++++++++++++++
11 files changed, 889 insertions(+), 517 deletions(-)
create mode 100644 include/linux/sbitmap.h
create mode 100644 lib/sbitmap.c
--
2.9.3
next reply other threads:[~2016-09-17 8:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-17 8:28 Omar Sandoval [this message]
2016-09-17 8:28 ` [PATCH v4 1/6] blk-mq: abstract tag allocation out into sbitmap library Omar Sandoval
2016-09-17 8:28 ` [PATCH v4 2/6] sbitmap: allocate wait queues on a specific node Omar Sandoval
2016-09-17 8:28 ` [PATCH v4 3/6] sbitmap: push per-cpu last_tag into sbitmap_queue Omar Sandoval
2016-09-17 8:28 ` [PATCH v4 4/6] sbitmap: push alloc policy " Omar Sandoval
2016-09-17 8:28 ` [PATCH v4 5/6] sbitmap: randomize initial alloc_hint values Omar Sandoval
2016-09-17 8:28 ` [PATCH v4 6/6] sbitmap: re-initialize allocation hints after resize Omar Sandoval
2016-09-17 14:42 ` [PATCH v4 0/6] blk-mq: generalization and bug fixes for tag allocation Jens Axboe
2016-09-17 19:20 ` [PATCH] sbitmap: don't update the allocation hint on clear after resize Omar Sandoval
2016-09-17 19:39 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1474100040.git.osandov@fb.com \
--to=osandov@osandov.com \
--cc=ast@fb.com \
--cc=axboe@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).