linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Omar Sandoval <osandov@osandov.com>
To: Jens Axboe <axboe@fb.com>, linux-block@vger.kernel.org
Cc: kernel-team@fb.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH 0/6] block: fix blk-mq debugfs vs. blktrace
Date: Tue, 31 Jan 2017 14:53:16 -0800	[thread overview]
Message-ID: <cover.1485902856.git.osandov@fb.com> (raw)

From: Omar Sandoval <osandov@fb.com>

When I moved the blk-mq debugging information to debugfs, I didn't
realize that blktrace also created directories in debugfs that
conflicted with the blk-mq directories. This series fixes that.

Patch 1 adds a new debugfs helper needed for patch 6. Greg, could I get
an ack on that if it makes sense? Jens and I went back and forth on this
for a little while, but patch 6 has more of the rationale on why we
decided that this approach was the cleanest.

Patches 2 and 3 are cleanups.

Patch 4 is the first part of the fix, making blk-mq and blktrace use the
same top-level "block" directory.

Patches 5 and 6 make blk-mq and blktrace play nicely with each other
w.r.t. the debugfs "block/$dev" directories.

I tested this with multiple configurations, so hopefully I didn't mess
that up this time.

Applies to for-4.11/block.

Thanks!

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Omar Sandoval (6):
  debugfs: add debugfs_lookup()
  block: fix debugfs config conditional in struct request_queue
  blktrace: make do_blk_trace_setup() static
  block: use same block debugfs directory for blk-mq and blktrace
  blk-mq: move debugfs_remove() of disk dir to blk_release_queue()
  blktrace: use existing disk debugfs directory

 block/blk-core.c             |  9 +++++++++
 block/blk-mq-debugfs.c       | 12 +++---------
 block/blk-mq-sysfs.c         |  2 +-
 block/blk-mq.c               |  2 --
 block/blk-mq.h               |  5 -----
 block/blk-sysfs.c            |  3 +++
 block/blk.h                  |  4 ++++
 fs/debugfs/inode.c           | 36 ++++++++++++++++++++++++++++++++++++
 include/linux/blkdev.h       |  2 +-
 include/linux/blktrace_api.h |  4 ----
 include/linux/debugfs.h      |  8 ++++++++
 kernel/trace/blktrace.c      | 35 +++++++++++++++--------------------
 12 files changed, 80 insertions(+), 42 deletions(-)

-- 
2.11.0


             reply	other threads:[~2017-01-31 22:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-31 22:53 Omar Sandoval [this message]
2017-01-31 22:53 ` [PATCH 1/6] debugfs: add debugfs_lookup() Omar Sandoval
2017-01-31 22:53 ` [PATCH 2/6] block: fix debugfs config conditional in struct request_queue Omar Sandoval
2017-01-31 22:53 ` [PATCH 3/6] blktrace: make do_blk_trace_setup() static Omar Sandoval
2017-01-31 22:53 ` [PATCH 4/6] block: use same block debugfs directory for blk-mq and blktrace Omar Sandoval
2017-01-31 22:53 ` [PATCH 5/6] blk-mq: move debugfs_remove() of disk dir to blk_release_queue() Omar Sandoval
2017-01-31 22:53 ` [PATCH 6/6] blktrace: use existing disk debugfs directory Omar Sandoval
2017-02-01  8:16 ` [PATCH 0/6] block: fix blk-mq debugfs vs. blktrace Greg Kroah-Hartman
2017-02-01  8:31   ` Omar Sandoval
2017-02-02 10:58     ` Greg Kroah-Hartman
2017-02-02 15:17       ` Jens Axboe
2017-02-02 17:18         ` Greg Kroah-Hartman
2017-02-02 17:01       ` Omar Sandoval
2017-02-02 17:18         ` Greg Kroah-Hartman
2017-02-02 17:20 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1485902856.git.osandov@fb.com \
    --to=osandov@osandov.com \
    --cc=axboe@fb.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-team@fb.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).