From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.220 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793268258; b=TOFIitsghExXEBa2+QY4lsvsugPSvOsRHRdBo8jKQkojCg/WOuwHPQhjXFulCYHcNLHM 6w6bCJKqtCLzfR5z4Z7MM/J48eFPE2GKNNIQYUGuln9Gh1BEphU6VjIg18FRpaCBmBzOt 08rinPomn5gSgd+7+m/7boaR+UB0R2hp7NOcjdeC6ztwFbqZsnKH2qFALs/TiQMOw48Hk CmI7xx2Dg81B14DV9bQa57YLQki4i5yDmGA4C+r1zVmU9ipQxyVCY7UkfreqlYs0CjwzQ w1qxEzz4cYkoOSsyJuaG00X2LIshb34pHIOeFWv8cl8qMSTWhSM/oWfaEmqq4xJW64A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793268258; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Message-ID:Date:MIME-Version:User-Agent: Cc:Subject:To:References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=LB/73nfCAHiY8ms6QFBHreSDwl9iYXEvUDaC3DV6Zu0=; b=u+8skgrhFG8X3hfPYLWGLoqTUbG/0b5zS9OK5oWop8uXRz5wITsip7Jb9ugUIvyK6Y+X iNIZ2UbE1HyY5qt2P4cs3dSvmeE1ANy3anjfSwdqUtXm4yjS9SMa1zw90iYoNvFkAdbki Xp/I4o0uLXffAL/B7RPWk+P5iwylpqfxTv40GoFSTQeO8qZDY/rpYr//5Flz41HNZnsYC kFousDr5zTFg1G7C/DUIpEvvwdZY6CDaYxk4ZJUuBSjYQoqDuDytF6tbVuj/EuukQf9iw 1Dp6tdsFDZWbgU5bDXHngTG6wQRQ0LkMWUKzWdIndfmul8s3qmYMKBF6f0YR/IXgvLw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=nTU78u7k; arc=none smtp.remote-ip=95.215.58.220 Received: from mta1.migadu.com (out-220.mta1.migadu.com [95.215.58.220]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F248B606A31E for ; Thu, 29 Oct 2026 10:04:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org F248B606A31E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=nTU78u7k X-Envelope-To: linux-block@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=BAYzLGPgGf5837fXM6g/DklP8VVuXY5OJdBGwkWAxDk=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1793268256; v=1; x=1793873056; b=nTU78u7kXKe6fJXb4mdOo3cLUl1W8+j6jW23IQ8ZbftY929IH6CvYEOhwBSWyHqCv+6MADeL 2mrGTD319VdqsFjeEqhWqGRa4AjJGEDt/ItJM5qhr9Mwnnrm7QD6V7fU+Lg1W90HpEWDpC/q9Re LUdXm7lMRptxlcA5rq9RRANU= X-Envelope-To: linux-block@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 9324b428c442bf0e; Thu, 29 Oct 2026 10:04:15 +0000 X-Mizu-Trace-ID: 9324b428c442bf0e X-Migadu-Flow: FLOW_OUT Message-ID: Date: Thu, 29 Oct 2026 18:04:07 +0800 X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: cui.tao@linux.dev, josef@toxicopanda.com, axboe@kernel.dk, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, andrii@kernel.org, eddyz87@gmail.com, ast@kernel.org, daniel@iogearbox.net, linux-kselftest@vger.kernel.org, cuitao@kylinos.cn, ameryhung@gmail.com, alexei.starovoitov@gmail.com Subject: Re: [PATCH 1/5] blk-iocost: move shared definitions to blk-iocost.h To: Tejun Heo References: <20261028143534.135968-1-cui.tao@linux.dev> <20261028143534.135968-2-cui.tao@linux.dev> <3f51067b3d4d549e8414bc19bb612cb5@kernel.org> From: Tao Cui In-Reply-To: <3f51067b3d4d549e8414bc19bb612cb5@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hello Tejun, 在 2026/10/29 04:09, Tejun Heo 写道: > Hello, Tao. > > On Wed, Oct 28, 2026 at 10:35:30PM +0800, Tao Cui wrote: >> -static struct blkcg_policy blkcg_policy_iocost; >> - >> -/* accessors and helpers */ >> -static struct ioc *rqos_to_ioc(struct rq_qos *rqos) > > This isn't a pure move. The comment is dropped here. > >> } >> >> - >> static int ioc_weight_show(struct seq_file *sf, void *v) > > The blank line removal is unrelated to the move. > >> + bool user_qos_params:1; >> + bool user_cost_model:1; >> + >> +}; > > The blank line is new, and 2/5 then replaces it. > Dropping patch 1 resolves all three: v12 folds the definitions back into blk-iocost.c with the original comments and spacing intact, so there is no move left to keep pure. Sorry, I should have caught these before posting. Thanks, Tao > Thanks. > > -- > tejun