From: Hannes Reinecke <hare@suse.de>
To: Jens Axboe <axboe@fb.com>, linux-block@vger.kernel.org
Cc: ming.lei@redhat.com, hch@lst.de
Subject: Re: [PATCH 7/7] Revert "mtip32xx: pass BLK_MQ_F_NO_SCHED"
Date: Tue, 2 May 2017 08:15:32 +0200 [thread overview]
Message-ID: <d0dbd814-671e-0d29-a5bf-e290f2f2f5a1@suse.de> (raw)
In-Reply-To: <1493391340-24629-8-git-send-email-axboe@fb.com>
On 04/28/2017 04:55 PM, Jens Axboe wrote:
> This reverts commit 4981d04dd8f1ab19e2cce008da556d7f099b6e68.
>
> The driver has been converted to using the proper infrastructure
> for issuing internal commands. This means it's now safe to use with
> the scheduling infrastruture, so we can now revert the change
> that turned off scheduling for mtip32xx.
>
> Reviewed-by: Ming Lei <ming.lei@redhat.com>
> Signed-off-by: Jens Axboe <axboe@fb.com>
> ---
> drivers/block/mtip32xx/mtip32xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
> index 9780c4d3697c..c598c5ac2fd0 100644
> --- a/drivers/block/mtip32xx/mtip32xx.c
> +++ b/drivers/block/mtip32xx/mtip32xx.c
> @@ -3964,7 +3964,7 @@ static int mtip_block_initialize(struct driver_data *dd)
> dd->tags.reserved_tags = 1;
> dd->tags.cmd_size = sizeof(struct mtip_cmd);
> dd->tags.numa_node = dd->numa_node;
> - dd->tags.flags = BLK_MQ_F_SHOULD_MERGE | BLK_MQ_F_NO_SCHED;
> + dd->tags.flags = BLK_MQ_F_SHOULD_MERGE;
> dd->tags.driver_data = dd;
> dd->tags.timeout = MTIP_NCQ_CMD_TIMEOUT_MS;
>
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg
GF: F. Imend�rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG N�rnberg)
prev parent reply other threads:[~2017-05-02 6:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 14:55 [PATCH v3 0/7] Fixup mtip32xx for scheduling Jens Axboe
2017-04-28 14:55 ` [PATCH 1/7] mtip32xx: get rid of 'atomic' argument to mtip_exec_internal_command() Jens Axboe
2017-04-28 14:55 ` [PATCH 2/7] mtip32xx: kill atomic argument to mtip_quiesce_io() Jens Axboe
2017-04-28 14:55 ` [PATCH 3/7] mtip32xx: abstract out "are any commands active" helper Jens Axboe
2017-04-28 14:55 ` [PATCH 4/7] blk-mq: add and export helper to tell if a request is reserved Jens Axboe
2017-04-28 15:04 ` Bart Van Assche
2017-04-28 15:22 ` Ming Lei
2017-05-02 6:12 ` Hannes Reinecke
2017-04-28 14:55 ` [PATCH 5/7] mtip32xx: convert internal command issue to block IO path Jens Axboe
2017-05-02 6:14 ` Hannes Reinecke
2017-04-28 14:55 ` [PATCH 6/7] blk-mq-sched: remove hack that bypasses scheduler for reserved requests Jens Axboe
2017-04-28 15:22 ` Ming Lei
2017-05-02 6:15 ` Hannes Reinecke
2017-04-28 14:55 ` [PATCH 7/7] Revert "mtip32xx: pass BLK_MQ_F_NO_SCHED" Jens Axboe
2017-05-02 6:15 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0dbd814-671e-0d29-a5bf-e290f2f2f5a1@suse.de \
--to=hare@suse.de \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox