From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <kbusch@meta.com>, linux-block@vger.kernel.org
Cc: hch@lst.de, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv2] block: enable passthrough command statistics
Date: Thu, 3 Oct 2024 09:40:42 -0600 [thread overview]
Message-ID: <d1738d8c-023d-4a37-9b49-f9b42290ccd2@kernel.dk> (raw)
In-Reply-To: <20241003153036.411721-1-kbusch@meta.com>
On 10/3/24 9:30 AM, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> Applications using the passthrough interfaces for IO want to continue
> seeing the disk stats. These requests had been fenced off from this
> block layer feature. While the block layer doesn't necessarily know what
> a passthrough command does, we do know the data size and direction,
> which is enough to account for the command's stats.
>
> Since tracking these has the potential to produce unexpected results,
> the passthrough stats are locked behind a new queue flag that needs to
> be enabled with the /sys/block/<dev>/queue/iostats_passthrough
> attribute.
Looks good to me.
--
Jens Axboe
next prev parent reply other threads:[~2024-10-03 15:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 15:30 [PATCHv2] block: enable passthrough command statistics Keith Busch
2024-10-03 15:40 ` Jens Axboe [this message]
2024-10-03 18:09 ` Jens Axboe
2024-10-04 5:38 ` Christoph Hellwig
2024-10-04 15:04 ` Keith Busch
2024-10-07 5:56 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1738d8c-023d-4a37-9b49-f9b42290ccd2@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox