From: Jens Axboe <axboe@kernel.dk>
To: Damien Le Moal <dlemoal@kernel.org>, Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org,
"Richard W . M . Jones" <rjones@redhat.com>,
Jeff Moyer <jmoyer@redhat.com>,
Jiri Jaburek <jjaburek@redhat.com>,
Bart Van Assche <bvanassche@acm.org>,
Hannes Reinecke <hare@suse.de>,
Chaitanya Kulkarni <kch@nvidia.com>,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Subject: Re: [PATCH] block: Fix elv_iosched_local_module handling of "none" scheduler
Date: Tue, 17 Sep 2024 07:19:18 -0600 [thread overview]
Message-ID: <d22d787a-6810-4e2e-8807-4144efc220a7@kernel.dk> (raw)
In-Reply-To: <3a93a3ac-18d3-4031-ba16-ce172d10e7f4@kernel.org>
On 9/17/24 7:18 AM, Damien Le Moal wrote:
> On 2024/09/17 15:14, Christoph Hellwig wrote:
>> On Tue, Sep 17, 2024 at 07:11:22AM -0600, Jens Axboe wrote:
>>> Whatever reshuffling people have in mind, that needs to happen AFTER
>>> this bug is sorted out.
>>
>> Yes. The fix from Damien will work, but reverting to the old behavior
>> of ignoring the request_module return value feel much better. I can
>> prepare a patch, but I didn't want to steal the credits from Damien.
>>
>
> OK. I can send a v2 ignoring the request_module() result, as it was before.
Sounds good, let's do that.
--
Jens Axboe
next prev parent reply other threads:[~2024-09-17 13:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 5:32 [PATCH] block: Fix elv_iosched_local_module handling of "none" scheduler Damien Le Moal
2024-09-17 5:53 ` Christoph Hellwig
2024-09-17 12:33 ` Ming Lei
2024-09-17 12:48 ` Damien Le Moal
2024-09-17 13:02 ` Ming Lei
2024-09-17 13:05 ` Christoph Hellwig
2024-09-17 13:11 ` Jens Axboe
2024-09-17 13:14 ` Christoph Hellwig
2024-09-17 13:17 ` Jens Axboe
2024-09-17 13:18 ` Damien Le Moal
2024-09-17 13:19 ` Jens Axboe [this message]
2024-09-17 11:55 ` Shinichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d22d787a-6810-4e2e-8807-4144efc220a7@kernel.dk \
--to=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jjaburek@redhat.com \
--cc=jmoyer@redhat.com \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=rjones@redhat.com \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).