From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C96F9EB64DA for ; Wed, 28 Jun 2023 22:51:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231134AbjF1WvY (ORCPT ); Wed, 28 Jun 2023 18:51:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231681AbjF1Wus (ORCPT ); Wed, 28 Jun 2023 18:50:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56FB655B6; Wed, 28 Jun 2023 15:47:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AF10461460; Wed, 28 Jun 2023 22:47:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8CCDC433C8; Wed, 28 Jun 2023 22:47:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687992470; bh=iCHH5R43XmfjIehaGr3uyk3TyzoFaEwfiZiYqtj6jXo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=PzwYM/3i2eWpLdn3jCs2M6UU2vBOFrl81PaCGyLL57Kvi8ic/kK2aXCHMdXmYfacc CopAVX46gTvMeOimIN/CwpnU4kkac7EPaPJMY9jG6/Ivq1H8pLZlgnBQYtrvc1Pab6 aBOc0ZS6ovFjS8TanLTzr+EcWAkI81f89El97SQsJRxyG7GVVWesbC7aATSL9W+7HZ gjRtWeys5yVR9SVFPB7ZdTXOxt5sAxYjpvTwDK9k5h5JrvSh6+HWZq+vKQZlGWVNvP Ypb8+mEYDuDKGAIwqvaupYcKjxrd8R05a1bE8g5cSQkr/XOiN4yeG+pPQRq0Z3OWc4 d0r4vCVmRu1qA== Message-ID: Date: Thu, 29 Jun 2023 07:47:47 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v4 1/4] ublk: change ublk IO command defines to enum To: Andreas Hindborg , Ming Lei Cc: Hans Holmberg , Aravind Ramesh , Jens Axboe , "open list:BLOCK LAYER" , Christoph Hellwig , Matias Bjorling , Andreas Hindborg , open list , gost.dev@samsung.com, Minwoo Im References: <20230628190649.11233-1-nmi@metaspace.dk> <20230628190649.11233-2-nmi@metaspace.dk> Content-Language: en-US From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20230628190649.11233-2-nmi@metaspace.dk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 6/29/23 04:06, Andreas Hindborg wrote: > From: Andreas Hindborg > > This change is in preparation for zoned storage support. > > Signed-off-by: Andreas Hindborg > --- > include/uapi/linux/ublk_cmd.h | 23 +++++++++++++++++------ > 1 file changed, 17 insertions(+), 6 deletions(-) > > diff --git a/include/uapi/linux/ublk_cmd.h b/include/uapi/linux/ublk_cmd.h > index 4b8558db90e1..471b3b983045 100644 > --- a/include/uapi/linux/ublk_cmd.h > +++ b/include/uapi/linux/ublk_cmd.h > @@ -229,12 +229,23 @@ struct ublksrv_ctrl_dev_info { > __u64 reserved2; > }; > > -#define UBLK_IO_OP_READ 0 > -#define UBLK_IO_OP_WRITE 1 > -#define UBLK_IO_OP_FLUSH 2 > -#define UBLK_IO_OP_DISCARD 3 > -#define UBLK_IO_OP_WRITE_SAME 4 > -#define UBLK_IO_OP_WRITE_ZEROES 5 > +enum ublk_op { > + UBLK_IO_OP_READ = 0, > + UBLK_IO_OP_WRITE = 1, > + UBLK_IO_OP_FLUSH = 2, > + UBLK_IO_OP_DISCARD = 3, > + UBLK_IO_OP_WRITE_SAME = 4, > + UBLK_IO_OP_WRITE_ZEROES = 5, > + UBLK_IO_OP_ZONE_OPEN = 10, > + UBLK_IO_OP_ZONE_CLOSE = 11, > + UBLK_IO_OP_ZONE_FINISH = 12, > + UBLK_IO_OP_ZONE_APPEND = 13, > + UBLK_IO_OP_ZONE_RESET = 15, > + __UBLK_IO_OP_DRV_IN_START = 32, > + __UBLK_IO_OP_DRV_IN_END = 96, > + __UBLK_IO_OP_DRV_OUT_START = __UBLK_IO_OP_DRV_IN_END, > + __UBLK_IO_OP_DRV_OUT_END = 160, > +}; This patch does not do what the title says. You are also introducing the zone operations, and the very obscure __UBLK_IO_OP_DRV_XXX operations without an explanation. Also, why the "__" prefix for these ? I do not see the point... Given that this is a uapi, a comment to explain the less obvious commands would be nice. So I think the change to an enum for the existing ops can be done either in patch 2 or as a separate patch and the introduction of the zone operations done in patch 3 or as a separate patch. > > #define UBLK_IO_F_FAILFAST_DEV (1U << 8) > #define UBLK_IO_F_FAILFAST_TRANSPORT (1U << 9) -- Damien Le Moal Western Digital Research