Linux block layer
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Eric Biggers <ebiggers3@gmail.com>, linux-block@vger.kernel.org
Cc: Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH] blk-mq: constify struct blk_mq_ops
Date: Thu, 30 Mar 2017 19:42:41 -0600	[thread overview]
Message-ID: <d361b0d6-505e-48b1-1357-cd76a91ae70e@kernel.dk> (raw)
In-Reply-To: <20170330203916.122167-1-ebiggers3@gmail.com>

On 03/30/2017 02:39 PM, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> Constify all instances of blk_mq_ops, as they are never modified.

Looks good to me, and a nice followup to:

commit f8a5b12247fe18f7fed801ad262a7ab190e1f848
Author: Jens Axboe <axboe@fb.com>
Date:   Tue Dec 13 09:24:51 2016 -0700

    blk-mq: make mq_ops a const pointer
    
    We never change it, make that clear.

as well.

-- 
Jens Axboe

      reply	other threads:[~2017-03-31  1:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-30 20:39 [PATCH] blk-mq: constify struct blk_mq_ops Eric Biggers
2017-03-31  1:42 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d361b0d6-505e-48b1-1357-cd76a91ae70e@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=ebiggers3@gmail.com \
    --cc=ebiggers@google.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox