From: Jens Axboe <axboe@kernel.dk>
To: Edward Adam Davis <eadavis@qq.com>, hare@suse.de
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+fcee6b76cf2e261c51a4@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH V2] block: no show partitions if partno corrupted
Date: Tue, 14 Jan 2025 07:16:31 -0700 [thread overview]
Message-ID: <d384b565-0be8-461d-ba8c-0185842c9d9c@kernel.dk> (raw)
In-Reply-To: <tencent_9E78266DF82CB96C549658EA5AED66CD240A@qq.com>
On 1/14/25 1:51 AM, Edward Adam Davis wrote:
> diff --git a/block/genhd.c b/block/genhd.c
> index 9130e163e191..8d539a4a3b37 100644
> --- a/block/genhd.c
> +++ b/block/genhd.c
> @@ -890,7 +890,9 @@ static int show_partition(struct seq_file *seqf, void *v)
>
> rcu_read_lock();
> xa_for_each(&sgp->part_tbl, idx, part) {
> - if (!bdev_nr_sectors(part))
> + int partno = bdev_partno(part);
> +
> + if (!bdev_nr_sectors(part) || WARN_ON(partno >= DISK_MAX_PARTS))
> continue;
> seq_printf(seqf, "%4d %7d %10llu %pg\n",
> MAJOR(part->bd_dev), MINOR(part->bd_dev),
This should be a WARN_ON_ONCE(), and please put warn-on's on a separate
line.
--
Jens Axboe
next prev parent reply other threads:[~2025-01-14 14:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <67841058.050a0220.216c54.0034.GAE@google.com>
2025-01-14 2:28 ` [PATCH] block: no show partitions if partno corrupted Edward Adam Davis
2025-01-14 7:21 ` Hannes Reinecke
2025-01-14 8:51 ` [PATCH V2] " Edward Adam Davis
2025-01-14 14:16 ` Jens Axboe [this message]
2025-01-14 14:58 ` [PATCH V3] " Edward Adam Davis
2025-01-14 15:02 ` Jens Axboe
2025-01-14 15:15 ` Edward Adam Davis
2025-01-14 15:25 ` Jens Axboe
2025-01-14 15:34 ` [PATCH V4] " Edward Adam Davis
2025-01-14 16:21 ` [PATCH V3] " Edward Adam Davis
2025-01-15 6:46 ` [PATCH V2] " Christoph Hellwig
2025-01-14 5:29 ` [syzbot] [fs?] KASAN: global-out-of-bounds Read in number syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d384b565-0be8-461d-ba8c-0185842c9d9c@kernel.dk \
--to=axboe@kernel.dk \
--cc=eadavis@qq.com \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+fcee6b76cf2e261c51a4@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox