From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Shin'ichiro Kawasaki <shinichiro@fastmail.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Cc: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Subject: Re: [PATCH blktests 2/9] common/scsi_debug, tests/*: re-define _have_scsi_debug
Date: Tue, 18 Apr 2023 20:10:53 +0000 [thread overview]
Message-ID: <d4201ec4-a2d5-2ae3-db86-be3437cfc7ff@nvidia.com> (raw)
In-Reply-To: <20230417124728.458630-3-shinichiro@fastmail.com>
On 4/17/23 05:47, Shin'ichiro Kawasaki wrote:
> From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
>
> As a preparation to adapt test cases to built-in scsi_debug module, re-
> define the _have_scsi_debug function. It checks that the scsi_debug
> module is built as a loadable module. Modify it to check that the
> scsi_debug module is available as built-in module or loadable module.
>
> Also replace all _have_scsi_debug calls in test cases with
> "_have_module scsi_debug" so that the change of _have_scsi_debug do not
> affect the test cases. Following commits will modify them to call
> _have_scsi_debug, only for test cases ready to run with built-in
> scsi_debug.
>
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> ---
>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2023-04-18 20:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 12:47 [PATCH blktests 0/9] support built-in scsi_debug Shin'ichiro Kawasaki
2023-04-17 12:47 ` [PATCH blktests 1/9] common/rc: skip module file check if modules path does not exist Shin'ichiro Kawasaki
2023-04-18 20:09 ` Chaitanya Kulkarni
2023-04-17 12:47 ` [PATCH blktests 2/9] common/scsi_debug, tests/*: re-define _have_scsi_debug Shin'ichiro Kawasaki
2023-04-18 20:10 ` Chaitanya Kulkarni [this message]
2023-04-17 12:47 ` [PATCH blktests 3/9] common/scsi_debug: factor out _setup_scsi_debug_vars Shin'ichiro Kawasaki
2023-04-18 20:11 ` Chaitanya Kulkarni
2023-04-17 12:47 ` [PATCH blktests 4/9] common/scsi_debug: introduce _configure_scsi_debug Shin'ichiro Kawasaki
2023-04-18 20:15 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4201ec4-a2d5-2ae3-db86-be3437cfc7ff@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
--cc=shinichiro@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).