From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 856841C5F27 for ; Wed, 15 Jul 2026 07:04:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784099089; cv=none; b=FpGzhDTZwoF5oRLUUnP+zXRkTvyCQWeNWjPePlKNqpJt9A4xsOqnXMXIdzgIGDyVhAZzzAG5dG3jslCfRqdkOxaqsdIVE54WLYmLDaMyo92AlOdAkNOAiYnmwUupjs0zcV3ZQOOgI06QjlNzc6rBaiMSVjygpOss7ujw6OCVaHk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784099089; c=relaxed/simple; bh=/zH0H886Ih8K+KPbJ6n56BpNclXSgD3BWLZZmGLMOiw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HzyRZC6YnfvMnYN2dmZwxSoiT26oUwzFTSZP51sr3eLM/BkbqlciuVkIhwTsuowhqwMCJHTk62DX6SH+TXimAF1338NKWXKhtEQgqHC5xKEnCwT6H03n2/vncZ02F5vLzvqS4F+RVbJnEazmh29pSJK6Pn89WiJuiF0uLC/t5FY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=tfBi9/51; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=lYW59uBQ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=tfBi9/51; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=lYW59uBQ; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="tfBi9/51"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="lYW59uBQ"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="tfBi9/51"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="lYW59uBQ" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 202DC78283; Wed, 15 Jul 2026 07:04:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1784099085; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=moy03FBMAoCRgC1asF1OxnbzQTW9SAkXCZnMHhvA3b8=; b=tfBi9/51IGefLdCEMzsn/+xS9OIXHjuP5bdY9oEQR6U3DSgGuSDpLeVvWj78udqcgBGCXO R08OsvX6mbn+HC9GFMv1cHtPDefKKK7/OSCqokI/bfhKDCOnOSS8TSbipzSmGLmWty5GLO DDlvPbHS74JMxE3CaYOXZOeIepvAxqk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1784099085; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=moy03FBMAoCRgC1asF1OxnbzQTW9SAkXCZnMHhvA3b8=; b=lYW59uBQsMHBtDvse9jLZ0mPwC8HDmtnW23F9Sb5UOfhULOwemqZpdVQi/3F7V78Y2kOlD dihzvjjRmOHkn3Dw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1784099085; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=moy03FBMAoCRgC1asF1OxnbzQTW9SAkXCZnMHhvA3b8=; b=tfBi9/51IGefLdCEMzsn/+xS9OIXHjuP5bdY9oEQR6U3DSgGuSDpLeVvWj78udqcgBGCXO R08OsvX6mbn+HC9GFMv1cHtPDefKKK7/OSCqokI/bfhKDCOnOSS8TSbipzSmGLmWty5GLO DDlvPbHS74JMxE3CaYOXZOeIepvAxqk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1784099085; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=moy03FBMAoCRgC1asF1OxnbzQTW9SAkXCZnMHhvA3b8=; b=lYW59uBQsMHBtDvse9jLZ0mPwC8HDmtnW23F9Sb5UOfhULOwemqZpdVQi/3F7V78Y2kOlD dihzvjjRmOHkn3Dw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EEF4B779AD; Wed, 15 Jul 2026 07:04:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 3ww8OQwxV2rSCQAAD6G6ig (envelope-from ); Wed, 15 Jul 2026 07:04:44 +0000 Message-ID: Date: Wed, 15 Jul 2026 09:04:44 +0200 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] block: handle huge zero folios in bio_free_folios To: Christoph Hellwig , Jens Axboe Cc: Keith Busch , Neptune , linux-block@vger.kernel.org References: <20260715064215.2934345-1-hch@lst.de> <20260715064215.2934345-2-hch@lst.de> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20260715064215.2934345-2-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Flag: NO X-Spamd-Result: default: False [-4.28 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.18)[-0.901]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[kernel.org,gmail.com,vger.kernel.org]; RCPT_COUNT_FIVE(0.00)[5]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[lst.de:email,suse.de:email,suse.de:mid,imap1.dmz-prg2.suse.org:helo] X-Spam-Level: X-Spam-Score: -4.28 On 7/15/26 8:42 AM, Christoph Hellwig wrote: > When CONFIG_PERSISTENT_HUGE_ZERO_FOLIO is enabled, iomap_dio_zero() can > add a huge zero folio to a zeroing bio, which needs special treatment > in bio_free_folios by also checking is_huge_zero_folio() in addition to > is_zero_folio(). > > Fixes: 8dd5e7c75d7b ("block: add helpers to bounce buffer an iov_iter into bios") > Signed-off-by: Christoph Hellwig > --- > block/bio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/bio.c b/block/bio.c > index f2a5f4d0a967..4d6e5f5f5710 100644 > --- a/block/bio.c > +++ b/block/bio.c > @@ -1302,7 +1302,7 @@ static void bio_free_folios(struct bio *bio) > bio_for_each_bvec_all(bv, bio, i) { > struct folio *folio = bvec_folio(bv); > > - if (!is_zero_folio(folio)) > + if (!is_zero_folio(folio) && !is_huge_zero_folio(folio)) > folio_put(folio); > } > } Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich