From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07352C38A2A for ; Sat, 9 May 2020 03:11:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D92D7216FD for ; Sat, 9 May 2020 03:11:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728618AbgEIDL6 (ORCPT ); Fri, 8 May 2020 23:11:58 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:38385 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728353AbgEIDL6 (ORCPT ); Fri, 8 May 2020 23:11:58 -0400 Received: by mail-pf1-f194.google.com with SMTP id y25so1995418pfn.5 for ; Fri, 08 May 2020 20:11:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=F/EYR5WZ7H19gjg7fUTL9+ugcKnWThveHDKpqmOeqC0=; b=BV8AmHIULSo50aeOoNtFo6pDAf/s9LH4cIaoUMK14jVioFwbaDhOKHwB4uswGenNfK uCj3Z1lHr6WKv8CGxWhbjQ56nuRFZQxSQonR72sp7/2+4fMDvcDBrJRfJqa8NXFFwlEX oT0klSm7jTRD4tOXX8stVudfQnmdxDhlQnahKbaJ7qDUWMBUPRq+qY0udvFoQ6j1cYEM tUtV0Sj+X07ol/vx+Dhygj6jMbxzCXoQFrzBBdvEiuRp9okhizRQmVbMgZrXN9bN4d8L QpKOftPTtsWkrSODPMGwQl4gptPVrD62pzJlA2eJ5XTFATSGd1qO8AjgCYSHQPTX1apj FoIQ== X-Gm-Message-State: AGi0PuZUbnbK2KGWslkPlEM7nARwcNK53KmOCXrqlTD92dLszEmJoTta pAYVopLge3XQAR1LqXgtWwk= X-Google-Smtp-Source: APiQypLL+IXH9UUY6/DmMJmMmX+lzV1eDa+a8dnSEd1V1cQrGXXlhBPiUq/VFuws8X9gvCOCTPht+w== X-Received: by 2002:a05:6a00:a:: with SMTP id h10mr5991054pfk.160.1588993917112; Fri, 08 May 2020 20:11:57 -0700 (PDT) Received: from ?IPv6:2601:647:4000:d7:1981:d78f:7563:fc3d? ([2601:647:4000:d7:1981:d78f:7563:fc3d]) by smtp.gmail.com with ESMTPSA id y10sm3178673pfb.53.2020.05.08.20.11.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 May 2020 20:11:56 -0700 (PDT) Subject: Re: [PATCH V10 06/11] blk-mq: prepare for draining IO when hctx's all CPUs are offline To: Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org, John Garry , Hannes Reinecke , Christoph Hellwig , Thomas Gleixner References: <20200505020930.1146281-1-ming.lei@redhat.com> <20200505020930.1146281-7-ming.lei@redhat.com> <756074a0-ea4b-5dcf-9348-e5b4f4414248@acm.org> <20200509020926.GB1392681@T590> From: Bart Van Assche Autocrypt: addr=bvanassche@acm.org; prefer-encrypt=mutual; keydata= mQENBFSOu4oBCADcRWxVUvkkvRmmwTwIjIJvZOu6wNm+dz5AF4z0FHW2KNZL3oheO3P8UZWr LQOrCfRcK8e/sIs2Y2D3Lg/SL7qqbMehGEYcJptu6mKkywBfoYbtBkVoJ/jQsi2H0vBiiCOy fmxMHIPcYxaJdXxrOG2UO4B60Y/BzE6OrPDT44w4cZA9DH5xialliWU447Bts8TJNa3lZKS1 AvW1ZklbvJfAJJAwzDih35LxU2fcWbmhPa7EO2DCv/LM1B10GBB/oQB5kvlq4aA2PSIWkqz4 3SI5kCPSsygD6wKnbRsvNn2mIACva6VHdm62A7xel5dJRfpQjXj2snd1F/YNoNc66UUTABEB AAG0JEJhcnQgVmFuIEFzc2NoZSA8YnZhbmFzc2NoZUBhY20ub3JnPokBOQQTAQIAIwUCVI67 igIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEHFcPTXFzhAJ8QkH/1AdXblKL65M Y1Zk1bYKnkAb4a98LxCPm/pJBilvci6boefwlBDZ2NZuuYWYgyrehMB5H+q+Kq4P0IBbTqTa jTPAANn62A6jwJ0FnCn6YaM9TZQjM1F7LoDX3v+oAkaoXuq0dQ4hnxQNu792bi6QyVdZUvKc macVFVgfK9n04mL7RzjO3f+X4midKt/s+G+IPr4DGlrq+WH27eDbpUR3aYRk8EgbgGKvQFdD CEBFJi+5ZKOArmJVBSk21RHDpqyz6Vit3rjep7c1SN8s7NhVi9cjkKmMDM7KYhXkWc10lKx2 RTkFI30rkDm4U+JpdAd2+tP3tjGf9AyGGinpzE2XY1K5AQ0EVI67igEIAKiSyd0nECrgz+H5 PcFDGYQpGDMTl8MOPCKw/F3diXPuj2eql4xSbAdbUCJzk2ETif5s3twT2ER8cUTEVOaCEUY3 eOiaFgQ+nGLx4BXqqGewikPJCe+UBjFnH1m2/IFn4T9jPZkV8xlkKmDUqMK5EV9n3eQLkn5g lco+FepTtmbkSCCjd91EfThVbNYpVQ5ZjdBCXN66CKyJDMJ85HVr5rmXG/nqriTh6cv1l1Js T7AFvvPjUPknS6d+BETMhTkbGzoyS+sywEsQAgA+BMCxBH4LvUmHYhpS+W6CiZ3ZMxjO8Hgc ++w1mLeRUvda3i4/U8wDT3SWuHcB3DWlcppECLkAEQEAAYkBHwQYAQIACQUCVI67igIbDAAK CRBxXD01xc4QCZ4dB/0QrnEasxjM0PGeXK5hcZMT9Eo998alUfn5XU0RQDYdwp6/kMEXMdmT oH0F0xB3SQ8WVSXA9rrc4EBvZruWQ+5/zjVrhhfUAx12CzL4oQ9Ro2k45daYaonKTANYG22y //x8dLe2Fv1By4SKGhmzwH87uXxbTJAUxiWIi1np0z3/RDnoVyfmfbbL1DY7zf2hYXLLzsJR mSsED/1nlJ9Oq5fALdNEPgDyPUerqHxcmIub+pF0AzJoYHK5punqpqfGmqPbjxrJLPJfHVKy goMj5DlBMoYqEgpbwdUYkH6QdizJJCur4icy8GUNbisFYABeoJ91pnD4IGei3MTdvINSZI5e Message-ID: Date: Fri, 8 May 2020 20:11:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200509020926.GB1392681@T590> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 2020-05-08 19:09, Ming Lei wrote: > On Fri, May 08, 2020 at 04:26:17PM -0700, Bart Van Assche wrote: >> On 2020-05-04 19:09, Ming Lei wrote: >>> @@ -391,6 +393,7 @@ struct blk_mq_ops { >>> enum { >>> BLK_MQ_F_SHOULD_MERGE = 1 << 0, >>> BLK_MQ_F_TAG_SHARED = 1 << 1, >>> + BLK_MQ_F_NO_MANAGED_IRQ = 1 << 2, >>> BLK_MQ_F_BLOCKING = 1 << 5, >>> BLK_MQ_F_NO_SCHED = 1 << 6, >>> BLK_MQ_F_ALLOC_POLICY_START_BIT = 8, >>> diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h >>> index 77d70b633531..24b3a77810b6 100644 >>> --- a/include/linux/cpuhotplug.h >>> +++ b/include/linux/cpuhotplug.h >>> @@ -152,6 +152,7 @@ enum cpuhp_state { >>> CPUHP_AP_SMPBOOT_THREADS, >>> CPUHP_AP_X86_VDSO_VMA_ONLINE, >>> CPUHP_AP_IRQ_AFFINITY_ONLINE, >>> + CPUHP_AP_BLK_MQ_ONLINE, >>> CPUHP_AP_ARM_MVEBU_SYNC_CLOCKS, >>> CPUHP_AP_X86_INTEL_EPB_ONLINE, >>> CPUHP_AP_PERF_ONLINE, >> >> Wouldn't BLK_MQ_F_NO_IRQ be a better name than BLK_MQ_F_NO_MANAGED_IRQ? > > No, what this patchset tries to do is to address request timeout or hang > issue in case that managed irq is applied in blk-mq driver. What is a managed IRQ? The following query did not produce a useful answer: $ git grep -nHi managed.irq Thanks, Bart.