From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98CD6C61DA4 for ; Sat, 11 Mar 2023 16:40:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230033AbjCKQkP (ORCPT ); Sat, 11 Mar 2023 11:40:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229658AbjCKQkO (ORCPT ); Sat, 11 Mar 2023 11:40:14 -0500 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAEE5ED for ; Sat, 11 Mar 2023 08:40:12 -0800 (PST) Received: by mail-pl1-x62e.google.com with SMTP id p20so8678153plw.13 for ; Sat, 11 Mar 2023 08:40:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; t=1678552812; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=f6N0Ulf25aeoYIge+QpxZr0rbx1RoYJ828lEZDXjf8Y=; b=4qg9VKu3vLo4bCMQJ1lLsSPxbAsaQK+BCQEzv+s8BjaTrzgGkSLPdtHP/zkXYnrZ1E 2qGDxhupxCKpPgaDCBSYT+ncBDyw5m3xHB+6kMTcSFpbyH11V8a3fyReIfuOagfArqFI uE27MwDu9aaGYk7CF8q8Vt5nQ9iwOIqqcaLHfp6QnTFV9I4TAYoohKXBCHhcUcUKg1HS KZoRwJHhenq6H68JeJnfBl81qINr25sK5P7bF3Jg4yyTM1CkRqbqnRiWF4DQwkzloGDo 6nzA9qT7nLXpstd4CtZ+LydjS1aRTJfOQpf1WVCEh5Q2t69ZhL/aVEbCbpEZMNKeB9t/ h0vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678552812; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f6N0Ulf25aeoYIge+QpxZr0rbx1RoYJ828lEZDXjf8Y=; b=DxGcqRBBb6hqRAlj9QQ+XKygMEZl+Jva8ztD5aewqKrudeKUXhqy0YiEMOy3LXelQC wASnIA0V7cqDBeuObT48POtorg9xJf0CMUkFC4CjBmvNksCMHM6G2bhbmlTVdVcaRzPq HVWuZEqDH/HmATvccTJ6hHtoDzZjQevI/zomLCk18pBGeW3WxlMsb4fmzJOzfU2COSOo v+IQ1v+uZd3ACJZ5lu2FvH49Fxw7qXjvZoqaqVdTdM1yBBjVEeYmro1dYSaFZwadUpbX 1JLPvleKQJ7a/nEeJhuGYHy8e2FwxbtE4YClqSiwoNwbb2LCPg5cRzF+Os84pwnJtcwA EGPA== X-Gm-Message-State: AO0yUKW8AsY8NoSzEXd1uEB3V6G+fNwVTUP0Ud2A0MrWE3hhAjcOgqTu adrRj7zOtAqTrV6FQcmgME1Ijw== X-Google-Smtp-Source: AK7set9fz5fdGt/ZU0CFXP9O85wO02qjjZE84smKSYAIQlQyoXRPazvJBu52ixyWt3231fvpWPvL4A== X-Received: by 2002:a17:903:1387:b0:19f:382d:9740 with SMTP id jx7-20020a170903138700b0019f382d9740mr448884plb.3.1678552811987; Sat, 11 Mar 2023 08:40:11 -0800 (PST) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id jx4-20020a170903138400b0019edf582a95sm1790401plb.20.2023.03.11.08.40.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Mar 2023 08:40:11 -0800 (PST) Message-ID: Date: Sat, 11 Mar 2023 09:40:10 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: Possible kernel fs block code regression in 6.2.3 umounting usb drives Content-Language: en-US To: Greg Kroah-Hartman , Eric Biggers Cc: stable@vger.kernel.org, Sasha Levin , Mike Cloaked , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Yu Kuai , Genes Lists References: <88b36c03-780f-61a5-4a66-e69072aa7536@sapience.com> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org n 3/11/23 2:32?AM, Greg Kroah-Hartman wrote: > On Fri, Mar 10, 2023 at 02:53:19PM -0800, Eric Biggers wrote: >> On Fri, Mar 10, 2023 at 04:08:21PM -0500, Genes Lists wrote: >>> On 3/10/23 15:23, Jens Axboe wrote: >>>> On 3/10/23 1:16?PM, Eric Biggers wrote: >>> ... >>>> But I would revert: >>>> >>>> bfe46d2efe46c5c952f982e2ca94fe2ec5e58e2a >>>> 57a425badc05c2e87e9f25713e5c3c0298e4202c >>>> >>>> in that order from 6.2.3 and see if that helps. Adding Yu. >>>> >>> Confirm the 2 Reverts fixed in my tests as well (nvme + sata drives). >>> Nasty crash - some needed to be power cycled as they hung on shutdown. >>> >>> Thank you! >>> >>> gene >>> >>> >> >> Great, thanks. BTW, 6.1 is also affected. A simple reproducer is to run: >> >> dmsetup create dev --table "0 128 zero" >> dmsetup remove dev >> >> The following kconfigs are needed for the bug to be hit: >> >> CONFIG_BLK_CGROUP=y >> CONFIG_BLK_DEV_THROTTLING=y >> CONFIG_BLK_DEV_THROTTLING_LOW=y >> >> Sasha or Greg, can you please revert the indicated commits from 6.1 and 6.2? > > Yes, will go do that right now, thanks for debugging this so quickly! The issue here is that parts of a series was auto-selected. That seems like a bad idea to do for stable. Just because something applies without other parts of the series doesn't mean it's sane to backport by itself. How do we prevent that from happening? Maybe we just need to default to "if whole series doesn't pick cleanly, don't grab any parts of it in auto-selection"? Exception being if it's explicitly marked for stable, not uncommon to have a series that starts with a fix or two which should go to stable, then the feature bits. -- Jens Axboe