Re: [PATCH] blk-mq: Fix more tag iteration function documentation

[John Garry <john.g.garry@oracle.com>]

On 22/09/2025 21:13, Bart Van Assche wrote:
> Commit 8ab30a331946 ("blk-mq: Drop busy_iter_fn blk_mq_hw_ctx argument")
> removed the hctx argument from the callback functions called by
> bt_for_each() and blk_mq_queue_tag_busy_iter(). Commit 2dd6532e9591
> ("blk-mq: Drop 'reserved' arg of busy_tag_iter_fn") removed the
> 'reserved' argument of the busy_tag_iter_fn function pointer type. Bring
> the documentation of the tag iteration functions in sync with these
> changes.
> 
> Cc: John Garry <john.g.garry@oracle.com>
> Cc: Ming Lei <ming.lei@redhat.com>
> Cc: Christoph Hellwig <hch@infradead.org>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>

Reviewed-by: John Garry <john.g.garry@oracle.com>

> ---
>   block/blk-mq-tag.c | 32 +++++++++++++++-----------------
>   1 file changed, 15 insertions(+), 17 deletions(-)
> 
> diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
> index 0602ca7f1e37..271fa005c51e 100644
> --- a/block/blk-mq-tag.c
> +++ b/block/blk-mq-tag.c
> @@ -297,15 +297,15 @@ static bool bt_iter(struct sbitmap *bitmap, unsigned int bitnr, void *data)
>   /**
>    * bt_for_each - iterate over the requests associated with a hardware queue
>    * @hctx:	Hardware queue to examine.
> - * @q:		Request queue to examine.
> + * @q:		Request queue @hctx is associated with (@hctx->queue).

eh, sometimes hctx is NULL, so it is odd to be saying that it is the q 
is associated with that (being NULL)