public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: alan.adamson@oracle.com
To: Christoph Hellwig <hch@lst.de>
Cc: linux-nvme@lists.infradead.org, kbusch@kernel.org,
	sagi@grimberg.me, linux-block@vger.kernel.org
Subject: Re: [RFC 0/1] nvme: Add NVMe LBA Fault Injection
Date: Wed, 24 Jan 2024 08:52:54 -0800	[thread overview]
Message-ID: <d63f74b2-b455-4fd4-9b32-2657c6d81588@oracle.com> (raw)
In-Reply-To: <20240124090453.GB27760@lst.de>


On 1/24/24 1:04 AM, Christoph Hellwig wrote:
> On Tue, Jan 23, 2024 at 09:25:51AM -0800, alan.adamson@oracle.com wrote:
>> I get it, but there is already an injection framework in place for nvme. Is
>> there no plan to improve it?
> Injecting fake I/O error really isn't the driver job.  For block
> I/O we could do it the block layer or DM, but that's not something
> to add to random drivers.  Error injection makes sense for testing
> the driver itself, not applications.

Thanks, I'll look at the block layer for this.  Do you think adding 
error injection to qemu-nvme makes sense?

Alan


  reply	other threads:[~2024-01-24 16:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240116232728.3392996-1-alan.adamson@oracle.com>
2024-01-18  7:24 ` [RFC 0/1] nvme: Add NVMe LBA Fault Injection Christoph Hellwig
2024-01-18 17:02   ` alan.adamson
2024-01-19  4:48     ` Keith Busch
2024-01-23  9:05     ` Christoph Hellwig
2024-01-23 17:25       ` alan.adamson
2024-01-24  9:04         ` Christoph Hellwig
2024-01-24 16:52           ` alan.adamson [this message]
2024-01-24 16:59             ` Keith Busch
2024-01-24 17:11               ` alan.adamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d63f74b2-b455-4fd4-9b32-2657c6d81588@oracle.com \
    --to=alan.adamson@oracle.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox