From: David Laight <David.Laight@ACULAB.COM>
To: 'Amey Narkhede' <ameynarkhede03@gmail.com>,
"justin@coraid.com" <justin@coraid.com>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] block: aoe: replace use of __constant_htons to htons
Date: Sun, 20 Dec 2020 19:35:54 +0000 [thread overview]
Message-ID: <d708db73308747feb0484287a09c443e@AcuMS.aculab.com> (raw)
In-Reply-To: <20201220164625.94105-1-ameynarkhede03@gmail.com>
From: Amey Narkhede
> Sent: 20 December 2020 16:46
>
> The macro htons expands to __swab16 which has special
> case for constants in little endian case. In big
> endian case both __constant_htons and htons macros
> expand to the same code. So, replace __constant_htons
> with htons to get rid of the definition of __constant_htons
> completely.
>
...
> static struct packet_type aoe_pt __read_mostly = {
> - .type = __constant_htons(ETH_P_AOE),
> + .type = htons(ETH_P_AOE),
> .func = aoenet_rcv,
Does this cause grief if someone is doing a COMPILE_TEST on LE?
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2020-12-20 19:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-20 16:46 [PATCH] block: aoe: replace use of __constant_htons to htons Amey Narkhede
2020-12-20 19:35 ` David Laight [this message]
[not found] ` <20201220202019.j7x64yahapgilr7u@archlinux>
[not found] ` <c5df63bdc5a94ebdac9505a64f2cece5@AcuMS.aculab.com>
2020-12-21 11:03 ` 'Amey Narkhede'
-- strict thread matches above, loose matches on Subject: below --
2020-12-20 20:56 'Amey Narkhede'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d708db73308747feb0484287a09c443e@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=ameynarkhede03@gmail.com \
--cc=axboe@kernel.dk \
--cc=justin@coraid.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox