From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3CDBC00140 for ; Wed, 10 Aug 2022 17:03:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233112AbiHJRDI (ORCPT ); Wed, 10 Aug 2022 13:03:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233153AbiHJRDG (ORCPT ); Wed, 10 Aug 2022 13:03:06 -0400 Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C3B065650 for ; Wed, 10 Aug 2022 10:03:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1660150984; x=1691686984; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=8Pq8CBGLyirGLAmHoB0J+qoIbqc9DpPo2RXP+p6Tvf4=; b=TSPj5Zzz2Bw39771aHItbP6A/mMwl6CBDL35dUR892F3t35OgXyk9yh0 KD2CfChyZMVl20rfNbZIx6F70vSJaqwP7VqNwL11MyodlRugi+hHRc/W2 rsiGK4U7XNTHF1k+fMxF58c+VlFyFZ30u9iotiFMuNPOMOhk1Z1mxkAmw EtIQZh6UzfaC0f/a/pjWgQnDJjWRca/kBAsi7M7Bm5L5YUvWUyq2h8KGN tE59W66Tfm+PAnL/a2CWbrSXaQrQ9YORvM8/c5i+IZLJdCPuK7L/uCHnE yDuXKKvARRvPBv99S2LO1rhx/+p+r4XIcEZ81ZkzRyyyli91cTmEwqCoa w==; X-IronPort-AV: E=Sophos;i="5.93,227,1654531200"; d="scan'208";a="208362733" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 11 Aug 2022 01:03:04 +0800 IronPort-SDR: 2jxto9kjxVLEbXTwd1/mJG5NcrWg+N7eCuC+8rU9gq8rZ5y8Rm0jNJ8B0nPOqcDpk/W23RBSYn zVEYk82Xz8SmHU4/C+NV3rMO9Y52D/dXszHpOEXlliJZ93bXKmw0L9PTCUh6i4csvbOhubqRcM KlFhInrela/pnICcpIabICmgbk03oItzp6cURa4GtE9dPlAhWARqyFgUMxvAGtUhhCPq6HK+5H e2/1B2RwnIj0U4iJPQPrFPHtWZAy89J1EM66Xv2moHHNEvLqph+6Y4OmPcTzL2Yx+bqjJQSm8L XAlKdmIP1AOobGKKYHH8/RQf Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 Aug 2022 09:18:40 -0700 IronPort-SDR: Tea+3/AvEJxTGfDlPGvN/fQ3QaqMfHSDWFjYVoESlpzFELI1WgGct0EeM9dwJusI83+cUqLytu LDz3I7NLiUzLxOVcTiKOAcPiaoHoF7YWRoNY46PtRazv8Mi1Ac9fIAT9q6AsI7PbZEs5qMw02U 9juxHpjg9g4ZWgWJUqGLTKE1asjPzUs1P3xfJH6d9igdjfQz8lKp7vgAGGA8D3n6u6xwuiP9gM t3Pgo0KcwNhqR+bJ2Y/VoDeBkjB0V0PTse18tOOVLBlSOmGfl9Q8Wt5TNn8p/+beLBG2NVerXH VOc= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 Aug 2022 10:03:05 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4M2x8S2YTdz1Rwnx for ; Wed, 10 Aug 2022 10:03:04 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1660150982; x=1662742983; bh=8Pq8CBGLyirGLAmHoB0J+qoIbqc9DpPo2RX P+p6Tvf4=; b=mIxnAHHgmrLJaSlMYWkHTKOnvX2dOxyKAGmqYVJvxo8HbGt1PA9 JhZtnp86GPv1WYMu/lqP8mRINS9VEzDmbR6vxZpgi9hqjMgHjTnRE2XAvuLs7/Al EPg1SmwR6KTalZZynFr1IEEqavsQN69W80Sn6y0ohMSx+pySCb79EhFKginjJeYx f36rzfUBQxrddpuxxONDYj2S1UMUwJ3mJXxu/Hb0A7xuYETFJ1DLN1E4Bg4OyvRt omDgvCNKmP2+p9TK74Ggpqi1ATVMwdHkHIvXx1ep2RKBgqlkPEmUnktbyCNxKnCv Ext7Qc86+bbFaS1kjSJldgVXWzOhUPmQt1g== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id RbHtp8PiuyGV for ; Wed, 10 Aug 2022 10:03:02 -0700 (PDT) Received: from [10.111.68.99] (c02drav6md6t.sdcorp.global.sandisk.com [10.111.68.99]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4M2x8P5ybyz1RtVk; Wed, 10 Aug 2022 10:03:01 -0700 (PDT) Message-ID: Date: Wed, 10 Aug 2022 10:03:01 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v9 03/13] block: allow blk-zoned devices to have non-power-of-2 zone size Content-Language: en-US To: Pankaj Raghav , Johannes.Thumshirn@wdc.com, snitzer@kernel.org, axboe@kernel.dk, agk@redhat.com, hch@lst.de Cc: dm-devel@redhat.com, matias.bjorling@wdc.com, gost.dev@samsung.com, linux-kernel@vger.kernel.org, pankydev8@gmail.com, jaegeuk@kernel.org, hare@suse.de, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, bvanassche@acm.org, Luis Chamberlain References: <20220803094801.177490-1-p.raghav@samsung.com> <20220803094801.177490-4-p.raghav@samsung.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20220803094801.177490-4-p.raghav@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 2022/08/03 2:47, Pankaj Raghav wrote: > Checking if a given sector is aligned to a zone is a common > operation that is performed for zoned devices. Add > bdev_is_zone_start helper to check for this instead of opencoding it > everywhere. > > Convert the calculations on zone size to be generic instead of relying on > power-of-2(po2) based arithmetic in the block layer using the helpers > wherever possible. > > The only hot path affected by this change for zoned devices with po2 > zone size is in blk_check_zone_append() but bdev_is_zone_start() helper is > used to optimize the calculation for po2 zone sizes. > > Finally, allow zoned devices with non po2 zone sizes provided that their > zone capacity and zone size are equal. The main motivation to allow zoned > devices with non po2 zone size is to remove the unmapped LBA between > zone capcity and zone size for devices that cannot have a po2 zone > capacity. > > Reviewed-by: Luis Chamberlain > Reviewed-by: Hannes Reinecke > Signed-off-by: Pankaj Raghav > --- > block/blk-core.c | 2 +- > block/blk-zoned.c | 24 ++++++++++++++++++------ > include/linux/blkdev.h | 30 ++++++++++++++++++++++++++++++ > 3 files changed, 49 insertions(+), 7 deletions(-) > > diff --git a/block/blk-core.c b/block/blk-core.c > index a0d1104c5590..1cb519220ffb 100644 > --- a/block/blk-core.c > +++ b/block/blk-core.c > @@ -563,7 +563,7 @@ static inline blk_status_t blk_check_zone_append(struct request_queue *q, > return BLK_STS_NOTSUPP; > > /* The bio sector must point to the start of a sequential zone */ > - if (bio->bi_iter.bi_sector & (bdev_zone_sectors(bio->bi_bdev) - 1) || > + if (!bdev_is_zone_start(bio->bi_bdev, bio->bi_iter.bi_sector) || > !bio_zone_is_seq(bio)) > return BLK_STS_IOERR; > > diff --git a/block/blk-zoned.c b/block/blk-zoned.c > index dce9c95b4bcd..665b822d13f9 100644 > --- a/block/blk-zoned.c > +++ b/block/blk-zoned.c > @@ -285,10 +285,10 @@ int blkdev_zone_mgmt(struct block_device *bdev, enum req_op op, > return -EINVAL; > > /* Check alignment (handle eventual smaller last zone) */ > - if (sector & (zone_sectors - 1)) > + if (!bdev_is_zone_start(bdev, sector)) > return -EINVAL; > > - if ((nr_sectors & (zone_sectors - 1)) && end_sector != capacity) > + if (!bdev_is_zone_start(bdev, nr_sectors) && end_sector != capacity) > return -EINVAL; > > /* > @@ -486,14 +486,26 @@ static int blk_revalidate_zone_cb(struct blk_zone *zone, unsigned int idx, > * smaller last zone. > */ > if (zone->start == 0) { > - if (zone->len == 0 || !is_power_of_2(zone->len)) { > - pr_warn("%s: Invalid zoned device with non power of two zone size (%llu)\n", > - disk->disk_name, zone->len); > + if (zone->len == 0) { > + pr_warn("%s: Invalid zero zone size", disk->disk_name); > + return -ENODEV; > + } > + > + /* > + * Non power-of-2 zone size support was added to remove the > + * gap between zone capacity and zone size. Though it is technically > + * possible to have gaps in a non power-of-2 device, Linux requires > + * the zone size to be equal to zone capacity for non power-of-2 > + * zoned devices. > + */ > + if (!is_power_of_2(zone->len) && zone->capacity < zone->len) { > + pr_err("%s: Invalid zone capacity: %lld with non power-of-2 zone size: %lld", > + disk->disk_name, zone->capacity, zone->len); > return -ENODEV; > } > > args->zone_sectors = zone->len; > - args->nr_zones = (capacity + zone->len - 1) >> ilog2(zone->len); > + args->nr_zones = div64_u64(capacity + zone->len - 1, zone->len); > } else if (zone->start + args->zone_sectors < capacity) { > if (zone->len != args->zone_sectors) { > pr_warn("%s: Invalid zoned device with non constant zone size\n", > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 22f97427b60b..5aa15172299d 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -709,6 +709,30 @@ static inline unsigned int disk_zone_no(struct gendisk *disk, sector_t sector) > return div64_u64(sector, zone_sectors); > } > > +static inline sector_t bdev_offset_from_zone_start(struct block_device *bdev, > + sector_t sec) > +{ > + sector_t zone_sectors = bdev_zone_sectors(bdev); > + u64 remainder = 0; > + > + if (!bdev_is_zoned(bdev)) > + return 0; > + > + if (is_power_of_2(zone_sectors)) > + return sec & (zone_sectors - 1); > + > + div64_u64_rem(sec, zone_sectors, &remainder); > + return remainder; > +} > + > +static inline bool bdev_is_zone_start(struct block_device *bdev, sector_t sec) > +{ > + if (!bdev_is_zoned(bdev)) > + return false; > + > + return bdev_offset_from_zone_start(bdev, sec) == 0; > +} > + > static inline bool disk_zone_is_seq(struct gendisk *disk, sector_t sector) > { > if (!blk_queue_is_zoned(disk->queue)) > @@ -753,6 +777,12 @@ static inline unsigned int disk_zone_no(struct gendisk *disk, sector_t sector) > { > return 0; > } > + > +static inline bool bdev_is_zone_start(struct block_device *bdev, sector_t sec) > +{ > + return false; > +} Is this one really necessary ? Any caller of this would also depend on CONFIG_BLK_DEV_ZONED and not compiled if not enabled. So there should be no callers of this for the !CONFIG_BLK_DEV_ZONED case. > + > static inline unsigned int bdev_max_open_zones(struct block_device *bdev) > { > return 0; -- Damien Le Moal Western Digital Research