* [PATCH blktests] nvme/040: fix write file path
@ 2022-07-29 0:15 Shin'ichiro Kawasaki
2022-08-04 6:47 ` Chaitanya Kulkarni
0 siblings, 1 reply; 3+ messages in thread
From: Shin'ichiro Kawasaki @ 2022-07-29 0:15 UTC (permalink / raw)
To: linux-block, linux-nvme, Sagi Grimberg
The test case nvme/040 performs I/O to a nvmf device file. However, it
specifies wrong path to the device file then the I/O is done to a
regular file. Hence fix the path.
Fixes: ebf197d1aea4 ("nvme: add nvmf reset/disconnect during traffic test")
Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
---
tests/nvme/040 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/nvme/040 b/tests/nvme/040
index 10c1815..04bd726 100755
--- a/tests/nvme/040
+++ b/tests/nvme/040
@@ -37,7 +37,7 @@ test() {
# start fio job
echo "starting background fio"
- _run_fio_rand_io --filename="${nvmedev}n1" --size=1g \
+ _run_fio_rand_io --filename="/dev/${nvmedev}n1" --size=1g \
--group_reporting --ramp_time=5 &> /dev/null &
sleep 5
--
2.36.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH blktests] nvme/040: fix write file path
2022-07-29 0:15 [PATCH blktests] nvme/040: fix write file path Shin'ichiro Kawasaki
@ 2022-08-04 6:47 ` Chaitanya Kulkarni
2022-08-04 7:54 ` Shinichiro Kawasaki
0 siblings, 1 reply; 3+ messages in thread
From: Chaitanya Kulkarni @ 2022-08-04 6:47 UTC (permalink / raw)
To: Shin'ichiro Kawasaki, linux-block@vger.kernel.org,
linux-nvme@lists.infradead.org, Sagi Grimberg
On 7/28/22 17:15, Shin'ichiro Kawasaki wrote:
> The test case nvme/040 performs I/O to a nvmf device file. However, it
> specifies wrong path to the device file then the I/O is done to a
> regular file. Hence fix the path.
>
> Fixes: ebf197d1aea4 ("nvme: add nvmf reset/disconnect during traffic test")
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH blktests] nvme/040: fix write file path
2022-08-04 6:47 ` Chaitanya Kulkarni
@ 2022-08-04 7:54 ` Shinichiro Kawasaki
0 siblings, 0 replies; 3+ messages in thread
From: Shinichiro Kawasaki @ 2022-08-04 7:54 UTC (permalink / raw)
To: Chaitanya Kulkarni
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Sagi Grimberg
On Aug 04, 2022 / 06:47, Chaitanya Kulkarni wrote:
> On 7/28/22 17:15, Shin'ichiro Kawasaki wrote:
> > The test case nvme/040 performs I/O to a nvmf device file. However, it
> > specifies wrong path to the device file then the I/O is done to a
> > regular file. Hence fix the path.
> >
> > Fixes: ebf197d1aea4 ("nvme: add nvmf reset/disconnect during traffic test")
> > Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> > ---
>
> Looks good.
>
> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Thanks for the review. I've applied this with an amendment in the commit title.
--
Shin'ichiro Kawasaki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-04 7:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-29 0:15 [PATCH blktests] nvme/040: fix write file path Shin'ichiro Kawasaki
2022-08-04 6:47 ` Chaitanya Kulkarni
2022-08-04 7:54 ` Shinichiro Kawasaki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox