From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8036D131E3C for ; Tue, 9 Apr 2024 15:17:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712675827; cv=none; b=UxXwSlNXZo50uEH4ujJgfZt4nY0zEoFx0xR9zydmBVv2N2t3B2uW3K7gNfuPxchPn++RDvpKhoXgHuSBZzky+7ZgZsOz+pkaGg7Pa1By9YdQnmWf3QxKi1pu4s0oMYDOzACcGLTEs88f+J4gjK6pS0Z5L9Px7IWCa+sZEKRjVPo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712675827; c=relaxed/simple; bh=GpV2fHcAbppCLh2u5U1+w9Mj9ggp/1FWwmBurNKmVg4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mrUvLSZiP4qBWLzSotIe4DzPA9/BIOO7V7QH8AugRg1AkjEjNBSJht6p5cGsC7gVGo6nKTSKgpIQq2Fy3hoPgc7xoJ738p08cgAjtQzix6EIVVO4MRDAxCSsPGW/FY5KQf9KnCePoDGtlrbGBZbjOUg1XF28OJXXtEqKu+t4v/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=i3SQKtc7; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="i3SQKtc7" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1e0e89faf47so15169805ad.1 for ; Tue, 09 Apr 2024 08:17:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1712675825; x=1713280625; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CFN5ra1aznPU86rqQVA8b3ykCxoSF9HNqWhAYFl+4RQ=; b=i3SQKtc7P/thvm9kGI8liCG9FOjophegSPeyiNb/uRjkg17xstMHL87hCGasu3QQHQ 8mEeJ61BoPO3DgfZRpWtkadOR+GnL7Zs09bh6VA8/FFfLIHP93FiLgvKhSc7vfDyZiNW Xz94pfZroZYYZzlDWi0iHpm8pI7YJ9ny6dKrHWQdnhvCkpHPvTQY/dDqJIwzQD2JBqhD izGClQjVKzVEOdw0jRNJr8J8zzaHuakCZc1BEjecx9e/RFWxtNyEQTBe6X2AWHR1h6cl bcd3lDRh0j+6AVytlPf14H08JMKLIcL8o4mq/13eenzYQxS+k25WhrkA/dZUoL+xD/rr k5eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712675825; x=1713280625; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CFN5ra1aznPU86rqQVA8b3ykCxoSF9HNqWhAYFl+4RQ=; b=Pyzpbx8qnnFPRBHrUaX/D+LlZKovpamYo4mU514ebc5NQXZ2g5uvM4LLyPOl15I+Fq m8GylPadS9Z7lSVjUzDky+ISGvnwXF3Ct9a/7d9sZy3fFO0dPYXtPSD8MAmIIVGVHVWY jvVHBoDTUNoYBqJSC4ZFou+hKbCEZu5xtc2ooRFqFB+2Mw3gnGoQrAeXVzLDqEdom5Tl q/97HNfHb6d/8KtPuOSimBoGaQfckpphOofZW02SQs5eOET7Y2X/rTUY/p2ghI8nd3ud nfNeYTE6wb5M7AsnnCh32JRxiNxX+SlmV/scnSr1jeUpLbz7yOi6M0rppUoNJZTPuFCc 4tVA== X-Forwarded-Encrypted: i=1; AJvYcCUA3ur6QBCHSMCYhm1NT6gDfUqlty6+d2FENbnxm+xw8XGxePC2xhLyxUuU9061Hzw0LIwOS8M2tJnJabhubKlNyr7hMESd3ke54bE= X-Gm-Message-State: AOJu0YyrazlWDPnGaZzSZdgksJ0/rbuXEZhjw024l8JvR80PzQaX00SA eJkSQ/sjidUdYdxD1RMN9NPzvcQuZDHncbVXEnAUFsjeMm+tysfjH6+YJRjJP/Rkkkb8KCZjGf6 I X-Google-Smtp-Source: AGHT+IEFav7+y9oyCqRY7zx1fepSUKQxh2+t7rbF9PdgaetXQkALGBsEsh+5vF07Bn24RD62f0/qxg== X-Received: by 2002:a17:903:22c8:b0:1e0:b5f2:3284 with SMTP id y8-20020a17090322c800b001e0b5f23284mr115142plg.0.1712675824751; Tue, 09 Apr 2024 08:17:04 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.194]) by smtp.gmail.com with ESMTPSA id b13-20020a170902ed0d00b001e0e8e4f7e3sm8947433pld.206.2024.04.09.08.17.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Apr 2024 08:17:04 -0700 (PDT) Message-ID: Date: Tue, 9 Apr 2024 09:17:02 -0600 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: API break, sysfs "capability" file Content-Language: en-US To: Christoph Hellwig , Lennart Poettering Cc: Keith Busch , Linux regressions mailing list , linux-block@vger.kernel.org, LKML References: <54e3c969-3ee8-40d8-91d9-9b9402001d27@leemhuis.info> <20240409141531.GB21514@lst.de> From: Jens Axboe In-Reply-To: <20240409141531.GB21514@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/9/24 8:15 AM, Christoph Hellwig wrote: > On Tue, Apr 09, 2024 at 10:19:09AM +0200, Lennart Poettering wrote: >> All I am looking for is a very simple test that returns me a boolean: >> is there kernel-level partition scanning enabled on this device or >> not. > > And we can add a trivial sysfs attribute for that. And I think we should. I don't know what was being smoked adding a sysfs interface that exposed internal flag values - and honestly what was being smoked to rely on that, but I think it's fair to say that the majority of the fuckup here is on the kernel side. > At this point we're just better off with a clean new interface. > And you can use the old hack for < 5.15 if you care strongly enough > or just talk distros into backporting it to make their lives easier. We should arguably just stable mark the patch adding the above simple interface. -- Jens Axboe