From: Liu Song <liusong@linux.alibaba.com>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] blk-mq: change bio_set_ioprio to inline
Date: Wed, 31 Aug 2022 08:48:49 +0800 [thread overview]
Message-ID: <d81db7ff-6c5a-ff8c-ca1e-6d08474c202b@linux.alibaba.com> (raw)
In-Reply-To: <0001ab1d-b4c0-2ac1-f902-c61216204aef@nvidia.com>
On 2022/8/30 20:48, Chaitanya Kulkarni wrote:
> On 8/30/22 02:45, Liu Song wrote:
>> From: Liu Song <liusong@linux.alibaba.com>
>>
>> Change "bio_set_ioprio" to inline to avoid calling overhead.
>>
>> Signed-off-by: Liu Song <liusong@linux.alibaba.com>
> for performance overhead please provide quantitative data
>
> -ck
>
This is a small adjustment, and even if performance comparison data is
obtained
for targeted design use cases, it is not universal. If the inline by the
compiler is
successful, the number of instructions will be reduced.
Thanks
>
next prev parent reply other threads:[~2022-08-31 0:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 9:45 [RFC PATCH] blk-mq: change bio_set_ioprio to inline Liu Song
2022-08-30 12:48 ` Chaitanya Kulkarni
2022-08-31 0:48 ` Liu Song [this message]
2022-08-30 13:59 ` Jens Axboe
2022-08-31 0:42 ` Liu Song
2022-08-31 0:59 ` Jens Axboe
2022-08-31 1:22 ` Liu Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d81db7ff-6c5a-ff8c-ca1e-6d08474c202b@linux.alibaba.com \
--to=liusong@linux.alibaba.com \
--cc=axboe@kernel.dk \
--cc=chaitanyak@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox