From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E176ECAAA1 for ; Wed, 31 Aug 2022 00:49:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231311AbiHaAtE (ORCPT ); Tue, 30 Aug 2022 20:49:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231992AbiHaAtA (ORCPT ); Tue, 30 Aug 2022 20:49:00 -0400 Received: from out30-43.freemail.mail.aliyun.com (out30-43.freemail.mail.aliyun.com [115.124.30.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE44DA4054; Tue, 30 Aug 2022 17:48:53 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=liusong@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0VNoHDv4_1661906930; Received: from 30.227.181.248(mailfrom:liusong@linux.alibaba.com fp:SMTPD_---0VNoHDv4_1661906930) by smtp.aliyun-inc.com; Wed, 31 Aug 2022 08:48:51 +0800 Message-ID: Date: Wed, 31 Aug 2022 08:48:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [RFC PATCH] blk-mq: change bio_set_ioprio to inline To: Chaitanya Kulkarni Cc: "linux-block@vger.kernel.org" , "axboe@kernel.dk" , "linux-kernel@vger.kernel.org" References: <1661852746-117244-1-git-send-email-liusong@linux.alibaba.com> <0001ab1d-b4c0-2ac1-f902-c61216204aef@nvidia.com> From: Liu Song In-Reply-To: <0001ab1d-b4c0-2ac1-f902-c61216204aef@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 2022/8/30 20:48, Chaitanya Kulkarni wrote: > On 8/30/22 02:45, Liu Song wrote: >> From: Liu Song >> >> Change "bio_set_ioprio" to inline to avoid calling overhead. >> >> Signed-off-by: Liu Song > for performance overhead please provide quantitative data > > -ck > This is a small adjustment, and even if performance comparison data is obtained for targeted design use cases, it is not universal. If the inline by the compiler is successful, the number of instructions will be reduced. Thanks >