* [PATCH] null_blk: Fix correct parameter desc for the module
@ 2025-08-15 4:30 Genjian
2025-08-15 5:23 ` Damien Le Moal
0 siblings, 1 reply; 3+ messages in thread
From: Genjian @ 2025-08-15 4:30 UTC (permalink / raw)
To: axboe, dlemoal, shinichiro.kawasaki, johannes.thumshirn, kch,
zhengqixing, willy, namcao, vincent.fu
Cc: linux-block, linux-kernel, zhanggenjian, Genjian Zhang
From: Genjian Zhang <zhanggenjian@kylinos.cn>
When executing modinfo null_blk, there is an error in the description
of module parameter mbps, and the output information of cache_size is
incomplete.The output of modinfo before and after applying this patch
is as follows:
Before:
[...]
parm: cache_size:ulong
[...]
parm: mbps:Cache size in MiB for memory-backed device.
Default: 0 (none) (uint)
[...]
After:
[...]
parm: cache_size:Cache size in MiB for memory-backed device.
Default: 0 (none) (ulong)
[...]
parm: mbps:Limit maximum bandwidth (in MiB/s).
Default: 0 (no limit) (uint)
[...]
Fixes: 058efe000b31 ("null_blk: add module parameters for 4 options")
Signed-off-by: Genjian Zhang <zhanggenjian@kylinos.cn>
---
drivers/block/null_blk/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
index 91642c9a3b29..f982027e8c85 100644
--- a/drivers/block/null_blk/main.c
+++ b/drivers/block/null_blk/main.c
@@ -223,7 +223,7 @@ MODULE_PARM_DESC(discard, "Support discard operations (requires memory-backed nu
static unsigned long g_cache_size;
module_param_named(cache_size, g_cache_size, ulong, 0444);
-MODULE_PARM_DESC(mbps, "Cache size in MiB for memory-backed device. Default: 0 (none)");
+MODULE_PARM_DESC(cache_size, "Cache size in MiB for memory-backed device. Default: 0 (none)");
static bool g_fua = true;
module_param_named(fua, g_fua, bool, 0444);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] null_blk: Fix correct parameter desc for the module
2025-08-15 4:30 [PATCH] null_blk: Fix correct parameter desc for the module Genjian
@ 2025-08-15 5:23 ` Damien Le Moal
2025-08-15 8:53 ` genjian zhang
0 siblings, 1 reply; 3+ messages in thread
From: Damien Le Moal @ 2025-08-15 5:23 UTC (permalink / raw)
To: Genjian, axboe, shinichiro.kawasaki, johannes.thumshirn, kch,
zhengqixing, willy, namcao, vincent.fu
Cc: linux-block, linux-kernel, Genjian Zhang
On 8/15/25 13:30, Genjian wrote:
> From: Genjian Zhang <zhanggenjian@kylinos.cn>
The patch title is a little strange. What about:
null_blk: Fix the description of the cache_size module argument
>
> When executing modinfo null_blk, there is an error in the description
> of module parameter mbps, and the output information of cache_size is
> incomplete.The output of modinfo before and after applying this patch
> is as follows:
>
> Before:
> [...]
> parm: cache_size:ulong
> [...]
> parm: mbps:Cache size in MiB for memory-backed device.
> Default: 0 (none) (uint)
> [...]
>
> After:
> [...]
> parm: cache_size:Cache size in MiB for memory-backed device.
> Default: 0 (none) (ulong)
> [...]
> parm: mbps:Limit maximum bandwidth (in MiB/s).
> Default: 0 (no limit) (uint)
> [...]
>
> Fixes: 058efe000b31 ("null_blk: add module parameters for 4 options")
>
Remove the blank line here.
> Signed-off-by: Genjian Zhang <zhanggenjian@kylinos.cn>
With these fixed,
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re:Re: [PATCH] null_blk: Fix correct parameter desc for the module
2025-08-15 5:23 ` Damien Le Moal
@ 2025-08-15 8:53 ` genjian zhang
0 siblings, 0 replies; 3+ messages in thread
From: genjian zhang @ 2025-08-15 8:53 UTC (permalink / raw)
To: Damien Le Moal
Cc: axboe, shinichiro.kawasaki, johannes.thumshirn, kch, zhengqixing,
willy, namcao, vincent.fu, linux-block, linux-kernel,
Genjian Zhang
At 2025-08-15 13:23:50, "Damien Le Moal" <dlemoal@kernel.org> wrote:
>On 8/15/25 13:30, Genjian wrote:
>> From: Genjian Zhang <zhanggenjian@kylinos.cn>
>
>The patch title is a little strange. What about:
>
>null_blk: Fix the description of the cache_size module argument
>
>>
>> When executing modinfo null_blk, there is an error in the description
>> of module parameter mbps, and the output information of cache_size is
>> incomplete.The output of modinfo before and after applying this patch
>> is as follows:
>>
>> Before:
>> [...]
>> parm: cache_size:ulong
>> [...]
>> parm: mbps:Cache size in MiB for memory-backed device.
>> Default: 0 (none) (uint)
>> [...]
>>
>> After:
>> [...]
>> parm: cache_size:Cache size in MiB for memory-backed device.
>> Default: 0 (none) (ulong)
>> [...]
>> parm: mbps:Limit maximum bandwidth (in MiB/s).
>> Default: 0 (no limit) (uint)
>> [...]
>>
>> Fixes: 058efe000b31 ("null_blk: add module parameters for 4 options")
>>
>
>Remove the blank line here.
>
>> Signed-off-by: Genjian Zhang <zhanggenjian@kylinos.cn>
>
>With these fixed,
>
>Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
>
>--
>Damien Le Moal
>Western Digital Research
Thank you for your suggestions. I will send a patch v2.
--
Genjian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-15 8:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-15 4:30 [PATCH] null_blk: Fix correct parameter desc for the module Genjian
2025-08-15 5:23 ` Damien Le Moal
2025-08-15 8:53 ` genjian zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).