From: Bart Van Assche <bvanassche@acm.org>
To: Yu Kuai <yukuai1@huaweicloud.com>,
hch@lst.de, kbusch@kernel.org, ming.lei@redhat.com,
axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yukuai3@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH RFC v2 8/8] blk-mq-tag: allow shared queue/hctx to get more driver tags
Date: Mon, 23 Oct 2023 13:46:55 -0700 [thread overview]
Message-ID: <d8b5db3c-cd0a-4e88-ae08-e17b97bdfc55@acm.org> (raw)
In-Reply-To: <20231021154806.4019417-9-yukuai1@huaweicloud.com>
On 10/21/23 08:48, Yu Kuai wrote:
> + if (!busy) {
> + ctl->timer_running = false;
> + } else {
> + ctl->timer.expires = jiffies + HZ;
> + add_timer(&ctl->timer);
> + }
> + spin_unlock_irq(&tags->lock);
[ ... ]
> +inc_busy:
> + atomic_inc(&info->busy_count);
> + if (!tags->ctl.timer_running &&
> + try_cmpxchg_relaxed(&tags->ctl.timer_running, &timer_running, true)) {
> + tags->ctl.timer.expires = jiffies + HZ;
> + add_timer(&tags->ctl.timer);
> + }
> }
So the choice has been made to let the timer expire after one second? I
think the choice of the timer value is important enough to mention it in
the patch description.
Thanks,
Bart.
next prev parent reply other threads:[~2023-10-23 20:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-21 15:47 [PATCH RFC v2 0/8] blk-mq: improve tag fair sharing Yu Kuai
2023-10-21 15:47 ` [PATCH RFC v2 1/8] blk-mq: factor out a structure from blk_mq_tags Yu Kuai
2023-10-21 15:48 ` [PATCH RFC v2 2/8] blk-mq: factor out a structure to store information for tag sharing Yu Kuai
2023-10-21 15:48 ` [PATCH RFC v2 3/8] blk-mq: add a helper to initialize shared_tag_info Yu Kuai
2023-10-21 15:48 ` [PATCH RFC v2 4/8] blk-mq: support to track active queues from blk_mq_tags Yu Kuai
2023-10-21 15:48 ` [PATCH RFC v2 5/8] blk-mq: precalculate available tags for hctx_may_queue() Yu Kuai
2023-10-21 15:48 ` [PATCH RFC v2 6/8] blk-mq: add new helpers blk_mq_driver_tag_busy/idle() Yu Kuai
2023-10-21 15:48 ` [PATCH RFC v2 7/8] blk-mq-tag: delay tag sharing until fail to get driver tag Yu Kuai
2023-10-21 15:48 ` [PATCH RFC v2 8/8] blk-mq-tag: allow shared queue/hctx to get more driver tags Yu Kuai
2023-10-23 20:46 ` Bart Van Assche [this message]
2023-10-24 1:07 ` Yu Kuai
2023-10-23 4:38 ` [PATCH RFC v2 0/8] blk-mq: improve tag fair sharing Ming Lei
2023-10-23 7:26 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8b5db3c-cd0a-4e88-ae08-e17b97bdfc55@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox