From: Jon Derrick <jonathan.derrick@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Scott Bauer <scott.bauer@intel.com>,
Rafael Antognolli <rafael.antognolli@intel.com>,
Jens Axboe <axboe@fb.com>
Subject: Re: [PATCHv4 4/4] block/sed: Embed function data into the function sequence
Date: Wed, 22 Feb 2017 07:35:36 -0700 [thread overview]
Message-ID: <d9164183-013f-eab9-9469-9631b0f85d89@intel.com> (raw)
In-Reply-To: <20170222071342.GA17472@lst.de>
On 02/22/2017 12:13 AM, Christoph Hellwig wrote:
>> + if (!lock_held)
>> + mutex_lock(&dev->dev_lock);
>
> No conditional locking, please. I guess I causesd this by asking you
> to remove __opal_lock_unlock, but it seems we'd either need to keep it
> in the end.
>
> Except for that the series looks fine to me.
>
> Jens: given that 1-3 are the important fixes how about you pick those
> up ASAP? They all also had my Reviewed-by for previous postings.
>
Thanks
I'll respin just 4/4 shortly with __opal_lock_unlock
next prev parent reply other threads:[~2017-02-22 14:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 18:59 [PATCHv4 0/4] OPAL patches, cont'd Jon Derrick
2017-02-21 18:59 ` [PATCHv4 4/4] block/sed: Embed function data into the function sequence Jon Derrick
2017-02-21 23:03 ` Scott Bauer
2017-02-22 7:13 ` Christoph Hellwig
2017-02-22 14:35 ` Jon Derrick [this message]
2017-02-22 16:10 ` Jens Axboe
2017-02-22 16:13 ` Scott Bauer
2017-02-22 16:47 ` Jens Axboe
2017-02-22 17:22 ` Keith Busch
2017-02-22 2:42 ` [PATCHv4 0/4] OPAL patches, cont'd Jens Axboe
2017-02-22 3:14 ` Scott Bauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9164183-013f-eab9-9469-9631b0f85d89@intel.com \
--to=jonathan.derrick@intel.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=rafael.antognolli@intel.com \
--cc=scott.bauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox