From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4986138DE1; Thu, 10 Oct 2024 14:47:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728571673; cv=none; b=ZAWou5Gozz3EtyW62Jx7kjxmXxl3tFipwdh0zTewhLeNXOCiPVcrsujYVTTpzLWTmSLaiyk6qLABtT9xHtrUWMsR9TqROCPM09MtY791Ns44JlUx/j5VG+fD7s0m1s5xGW0pOEKxbykrxtr8A+P0uDwN/HQO2jDzc1FfYyxLDDY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728571673; c=relaxed/simple; bh=AIka2hYIMRtZJLFpx8KuFmzIeRctFctGZ8M/KuQJSZQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=usk41K3BbFsNeRJ/2gU+7teqXqbvl+8PUbGMiFrEzKF6jvHnb1CMrgwegZNLWJaBTc44IpR8Ho6R0yZfGBvQUjOhrbpOAoMpF/K8K28pgh3TSQbxtiZ0gNdij2xl5B+/Ig6tu6E79M3e6p1qJMng1F/9L7iLhUYbUSlcB9Xu4YY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=fjxkuoVd; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=6e8BIXC8; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=fjxkuoVd; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=6e8BIXC8; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="fjxkuoVd"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="6e8BIXC8"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="fjxkuoVd"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="6e8BIXC8" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4CCFD21D12; Thu, 10 Oct 2024 14:47:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1728571670; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MeWOxdYhWBqRDdWRkA0HNTcqby3S9Ndz/tGgBkoI4+E=; b=fjxkuoVdu4wisgWh/UV7VjjPoszqpwii1aaRElQAoHPuSWhNVLJiK8APUn6IlXyTehxUEI eHebpk6HhghJAXmAbPnhD9t/qc7YBt5NNi/cDYP/9TyX7CVPqtI49hjbwGTUDtTdGjuL14 fczsaOuAUciqRp6qv03tac4VMFetRVk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1728571670; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MeWOxdYhWBqRDdWRkA0HNTcqby3S9Ndz/tGgBkoI4+E=; b=6e8BIXC8UToX786zeAxjfaQdHEeP9D4XGRsq9pzt6iU9HD+kan85xOocaNCt/V99Vdow5d zxaDetQYjQozCTDQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=fjxkuoVd; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=6e8BIXC8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1728571670; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MeWOxdYhWBqRDdWRkA0HNTcqby3S9Ndz/tGgBkoI4+E=; b=fjxkuoVdu4wisgWh/UV7VjjPoszqpwii1aaRElQAoHPuSWhNVLJiK8APUn6IlXyTehxUEI eHebpk6HhghJAXmAbPnhD9t/qc7YBt5NNi/cDYP/9TyX7CVPqtI49hjbwGTUDtTdGjuL14 fczsaOuAUciqRp6qv03tac4VMFetRVk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1728571670; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MeWOxdYhWBqRDdWRkA0HNTcqby3S9Ndz/tGgBkoI4+E=; b=6e8BIXC8UToX786zeAxjfaQdHEeP9D4XGRsq9pzt6iU9HD+kan85xOocaNCt/V99Vdow5d zxaDetQYjQozCTDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 27FB01370C; Thu, 10 Oct 2024 14:47:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ygtkBxbpB2cobgAAD6G6ig (envelope-from ); Thu, 10 Oct 2024 14:47:50 +0000 Date: Thu, 10 Oct 2024 16:47:49 +0200 From: Daniel Wagner To: Matias =?utf-8?B?QmrDuHJsaW5n?= Cc: Christoph Hellwig , kbusch@kernel.org, dlemoal@kernel.org, cassel@kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Matias =?utf-8?B?QmrDuHJsaW5n?= Subject: Re: [PATCH 1/2] nvme: make independent ns identify default Message-ID: References: <20241008145503.987195-1-m@bjorling.me> <20241008145503.987195-2-m@bjorling.me> <20241009074611.GB16181@lst.de> <0076eb5e-6816-490e-abaf-a0a4a25a2915@bjorling.me> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0076eb5e-6816-490e-abaf-a0a4a25a2915@bjorling.me> X-Rspamd-Queue-Id: 4CCFD21D12 X-Spam-Score: -4.51 X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; TO_DN_SOME(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; FUZZY_BLOCKED(0.00)[rspamd.com]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_SEVEN(0.00)[9]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:dkim]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Flag: NO X-Spam-Level: On Wed, Oct 09, 2024 at 03:19:59PM GMT, Matias Bjørling wrote: > On 09-10-2024 09:46, Christoph Hellwig wrote: > > On Tue, Oct 08, 2024 at 04:55:02PM +0200, Matias Bjørling wrote: > > > However, the independent namespace data structure > > > is mandatory for devices that implement features from the 2.0+ > > > specification. Therefore, we can check this data structure first. If > > > unavailable, retrieve the generic attributes from the NVM command set > > > identify namespace data structure. > > > > I'm not a huge fan of this. For pre-2.0 controllers this means > > we'll now send a command that will fail most of them time. And for > > all the cheap low-end consumer device I'm actually worried that they'll > > get it wrong and break something. > > > > It's a good point. Damien, Keith, and I were debating it during ALPSS. They > preferred the "send command and see if it fails" approach over writing > specific conditions where it would apply. Note that Keith did suggest to > avoid the command on 1.0 and 1.1 devices, and they were known to fail with > unsupported CNS ids. FWIW, there are some devices out there which will log these attempts and spam their error logs. There were plenty of reports against nvme-cli when nvme-cli issued a command which could fail.