From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>, Ingo Molnar <mingo@redhat.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Optimise io_uring completion waiting
Date: Tue, 24 Sep 2019 13:15:52 +0200 [thread overview]
Message-ID: <da86ec56-5f14-536d-2d43-2cc9e118d2a7@kernel.dk> (raw)
In-Reply-To: <08193e07-6f05-a496-492d-06ed8ce3aea1@gmail.com>
On 9/24/19 5:11 AM, Pavel Begunkov wrote:
> On 24/09/2019 13:34, Jens Axboe wrote:
>> On 9/24/19 4:13 AM, Jens Axboe wrote:
>>> On 9/24/19 3:49 AM, Peter Zijlstra wrote:
>>>> On Tue, Sep 24, 2019 at 10:36:28AM +0200, Jens Axboe wrote:
>>>>
>>>>> +struct io_wait_queue {
>>>>> + struct wait_queue_entry wq;
>>>>> + struct io_ring_ctx *ctx;
>>>>> + struct task_struct *task;
>>>>
>>>> wq.private is where the normal waitqueue stores the task pointer.
>>>>
>>>> (I'm going to rename that)
>>>
>>> If you do that, then we can just base the io_uring parts on that.
>>
>> Just took a quick look at it, and ran into block/kyber-iosched.c that
>> actually uses the private pointer for something that isn't a task
>> struct...
>>
>
> Let reuse autoremove_wake_function anyway. Changed a bit your patch:
Yep that should do it, and saves 8 bytes of stack as well.
BTW, did you test my patch, this one or the previous? Just curious if it
worked for you.
--
Jens Axboe
next prev parent reply other threads:[~2019-09-24 11:16 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-22 8:08 [PATCH v2 0/2] Optimise io_uring completion waiting Pavel Begunkov (Silence)
2019-09-22 8:08 ` [PATCH v2 1/2] sched/wait: Add wait_threshold Pavel Begunkov (Silence)
2019-09-23 7:19 ` Peter Zijlstra
2019-09-23 16:37 ` Pavel Begunkov
2019-09-23 19:27 ` Peter Zijlstra
2019-09-23 20:23 ` Peter Zijlstra
2019-09-24 6:44 ` Pavel Begunkov
2019-09-22 8:08 ` [PATCH v2 2/2] io_uring: Optimise cq waiting with wait_threshold Pavel Begunkov (Silence)
2019-09-22 15:51 ` [PATCH v2 0/2] Optimise io_uring completion waiting Jens Axboe
2019-09-23 8:35 ` Ingo Molnar
2019-09-23 16:21 ` Pavel Begunkov
2019-09-23 16:32 ` Pavel Begunkov
2019-09-23 20:48 ` Jens Axboe
2019-09-23 23:00 ` Jens Axboe
2019-09-24 7:06 ` Pavel Begunkov
2019-09-24 8:02 ` Jens Axboe
2019-09-24 8:27 ` Jens Axboe
2019-09-24 8:36 ` Jens Axboe
2019-09-24 9:33 ` Pavel Begunkov
2019-09-24 10:11 ` Jens Axboe
2019-09-24 9:49 ` Peter Zijlstra
2019-09-24 10:13 ` Jens Axboe
2019-09-24 10:34 ` Jens Axboe
2019-09-24 11:11 ` Pavel Begunkov
2019-09-24 11:15 ` Jens Axboe [this message]
2019-09-24 11:23 ` Pavel Begunkov
2019-09-24 13:13 ` Jens Axboe
2019-09-24 17:33 ` Pavel Begunkov
2019-09-24 17:46 ` Jens Axboe
2019-09-24 18:28 ` Pavel Begunkov
2019-09-24 19:32 ` Jens Axboe
2019-09-24 11:43 ` Peter Zijlstra
2019-09-24 12:57 ` Jens Axboe
2019-09-24 11:33 ` Peter Zijlstra
2019-09-24 9:20 ` Pavel Begunkov
2019-09-24 10:09 ` Jens Axboe
2019-09-24 9:21 ` Pavel Begunkov
2019-09-24 10:09 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da86ec56-5f14-536d-2d43-2cc9e118d2a7@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).