From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC70FC433EF for ; Sun, 17 Oct 2021 12:59:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9733360FED for ; Sun, 17 Oct 2021 12:59:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343636AbhJQNBi (ORCPT ); Sun, 17 Oct 2021 09:01:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343588AbhJQNBe (ORCPT ); Sun, 17 Oct 2021 09:01:34 -0400 Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF6C5C061765 for ; Sun, 17 Oct 2021 05:59:24 -0700 (PDT) Received: by mail-io1-xd29.google.com with SMTP id x1so13117310iof.7 for ; Sun, 17 Oct 2021 05:59:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ytX4HdIZmZ28e1ub8YIdiheHvRBS77VmJQMUomMwZkA=; b=b2D1jO0GcUxp7achKObI+Nv8UhJt1FNRDu1AyUc9+GJ849mv89fpQRQp6IRF1UZKvs Vr1AoR+naW9m9uEQnSrSVCPdouciTZRAi/ZVdmkKeZKmOc9JNn8VaovuT5VVxsjMR1KD 8zNfTLGBaAvFb2fT26a8KFooz8U4VrXYRZdFw4tFt1uJRzN4hEOTgyfs+J7DAmh1LSRv XjfQoIPKU6gnVyTjdQ9aoTJKcYP7sITOmaOJtwKKpRKKvJ2XeWmPUXPWH5LYHgxsefkV /AdTg6rBNEFrT21voZkAQOwJIXq0uk1RMboPKEvJOuNv1UlH1d3Xmhekk29Un3mt8Oxc /JEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ytX4HdIZmZ28e1ub8YIdiheHvRBS77VmJQMUomMwZkA=; b=wsG0tJNYpPMmITrzAn6D+pIC12Z6umYEdVvM4/Y4X/xD7BHqnGs4t0rREvCI7xVsOH 6g7CEpwLpBQYVQPSoGXq1vifzVsSgxhVx34sha+6usRto4CyM5UGTwDbRcp2nTADh9SK 2nZlsIogNFvyD5ZlqYj1SbvuS8DGNtMDzvptdBRuWP3bo3i5tkZv6UE1pn9zwm3tnys9 P+kR6sIhXNWSaEQupRHUlpOfUxL+dtFlXsehlpvF7YDU37Tc2oIZTRtqgPLIHIfiDTFo d+iAd8SBctCsM6CeogG/Hd3YUSUWG+bKkENb5lMmelPKMgVtY/e8ALF1hcW9oHCpwRq0 FbWg== X-Gm-Message-State: AOAM532DJU2bHNTzJpTdxEFHFbwRQTAufcOz6QUvVBomZdBrjK5smTSH LulXNz+GLpS6FR1jTvI54vloWQ== X-Google-Smtp-Source: ABdhPJynKQdq8QvliNhrBE29N1TiRlprCrIimKQqCsGfTIN8WfnfzrKPRWW++mb6W8hidJYfWUomyg== X-Received: by 2002:a02:cb94:: with SMTP id u20mr14596094jap.134.1634475564268; Sun, 17 Oct 2021 05:59:24 -0700 (PDT) Received: from [192.168.1.116] ([66.219.217.159]) by smtp.gmail.com with ESMTPSA id h10sm5367427ilh.48.2021.10.17.05.59.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Oct 2021 05:59:23 -0700 (PDT) Subject: Re: [PATCH 0/5] cache request_queue pointer To: Pavel Begunkov , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Christoph Hellwig References: From: Jens Axboe Message-ID: Date: Sun, 17 Oct 2021 06:59:22 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 10/14/21 8:03 AM, Pavel Begunkov wrote: > Cache request_queue in bdev and replace two derefs in > bdev->bd_disk->queue with bdev->bd_queue. Benchmarking > with nullblk gave me around +1% to peak perf. > > All patches are self contained and don't rely on others from > the set including 1/5 and can be taken separately. And some > changes go in separate patches to minimise conflicts. When > we agree on the approach, I'll send the rest converting some > other spots out of block. Looks fine to me. Christoph, any concerns? One note, though - s/fater/faster in patches 2..5 in the commit message. -- Jens Axboe