From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BD00C4332F for ; Wed, 30 Mar 2022 13:49:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346344AbiC3Nvh (ORCPT ); Wed, 30 Mar 2022 09:51:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346322AbiC3Nvg (ORCPT ); Wed, 30 Mar 2022 09:51:36 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85350E339D for ; Wed, 30 Mar 2022 06:49:50 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id w8so20493030pll.10 for ; Wed, 30 Mar 2022 06:49:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=pTPymMdQgFl+qNBk1dkxT3ma9TeBkKnfldwjxUhrxOk=; b=MK5oAgTfTbUi11X1MeAaypUSJynlIL4eda9F8PDqjoTB/C+cg5WtqnYT394Ssh2/1j Ca4ZKqK/3bEJSSuWIzOIU3LDc4LVd04RqAIK4ehScUYH4PnwiInhTx9gBbXxxWe8RiUd hkQ9x8wZtIVR9KgQJ+hjBAwOKtqGW5v6c6MqnaoMBZp9bRo1n7SGmg+XUNapHbg3MYNA EmXxEir+x34H6VmkoRMK1W9V11VPzxkk6M5ThGQdRq4j8PXorqe+zcSnUWr28ynu3HtK UVeNhqFBF1pUlrTB2XsAedLwRBA0vmx2sgEpBfJlR7CyUOYlN4eNY8zRyXXtMwSxY6an FkmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=pTPymMdQgFl+qNBk1dkxT3ma9TeBkKnfldwjxUhrxOk=; b=rwzBYP7jB9lIwaNAyNNjZeiCsoksYEznpSmYntWTLxWXDuQGsQBagPJj42KGGcEmtT paEAGzynGc6+CzX/q0lJq2W0gOgBD9Snu2UVA5iB5UiHEl1U4b2UYdGUCnwVTBqFduPS pDTW8W6N57WVBQuRioVpuWOfxqmm3txSx+qRUMFJSEU1Z1MdRE0vL9gJuWi5Ml3qzyGv JvleesV1kFMaEATTS82+w+kRccQQWuVcktCK0zTJkVZYohyKb9hGhlfzVoGPVFmzI7/W GEA2l3saxjxi5IKt8Gkxqpg7xLM1jlU23kennjbrRA+mQcBKRlI6l4Jdz/z+rC8uw0LY 6peg== X-Gm-Message-State: AOAM530r1gM6xjEl6n9xO2dO0MzZSAAZ1WM+ao8IC+B2jAgVXVbAb4QD a2K9Nnhlj1ViN0PTdVxG0+1Nrw== X-Google-Smtp-Source: ABdhPJyil2ooSr7lhSFj2wMmQw4oKk0xYR7aRhy/GD4hCEPATCC87hH9099pofRsVbZcfOiXhXlueA== X-Received: by 2002:a17:902:7781:b0:153:35ef:e3d1 with SMTP id o1-20020a170902778100b0015335efe3d1mr36386212pll.116.1648648189964; Wed, 30 Mar 2022 06:49:49 -0700 (PDT) Received: from [192.168.1.100] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id h12-20020a056a00230c00b004faf2563bcasm23262164pfh.114.2022.03.30.06.49.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Mar 2022 06:49:49 -0700 (PDT) Message-ID: Date: Wed, 30 Mar 2022 07:49:48 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] block/psi: make PSI annotations of submit_bio only work for file pages Content-Language: en-US To: Christoph Hellwig , Johannes Weiner Cc: CGEL , viro@zeniv.linux.org.uk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, Yang Yang , Ran Xiaokai References: <20220316063927.2128383-1-yang.yang29@zte.com.cn> <623938d1.1c69fb81.52716.030f@mx.google.com> <20220323061058.GA2343452@cgel.zte@gmail.com> <62441603.1c69fb81.4b06b.5a29@mx.google.com> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 3/30/22 7:04 AM, Christoph Hellwig wrote: > On Wed, Mar 30, 2022 at 09:00:46AM -0400, Johannes Weiner wrote: >> If you want type distinction, we should move it all into MM code, like >> Christoph is saying. Were swap code handles anon refaults and the page >> cache code handles file refaults. This would be my preferred layering, >> and my original patch did that: https://lkml.org/lkml/2019/7/22/1070. > > FYI, I started redoing that version and I think with all the cleanups > to filemap.c and the readahead code this can be done fairly nicely now: > > http://git.infradead.org/users/hch/block.git/commitdiff/666abb29c6db870d3941acc5ac19e83fbc72cfd4 This looks way better than hiding it deep down in the block layer. -- Jens Axboe