Re: [PATCH 3/5] block: factor out a bio_await helper

Christoph Hellwig
2026-04-08T05:11:53Z

On Tue, Apr 07, 2026 at 07:59:57AM -0700, Bart Van Assche wrote:
>> }
> The comment above bio_await() says that the callback function passed as
> third argument submits the bio. The above code passes bio_end_cb as the
> "submit" argument. bio_end_cb() does something else than submitting a
> bio. How about renaming the "submit" argument of bio_await() into
> something else, e.g. "cb" or "callback" to make its role more clear?

It was called kick and Damien objected politely. A direct completion
isn't really distinguishable from a submission anyway, submit_bio
could complete the bio with an error before doing much.