From: Nilay Shroff <nilay@linux.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-block@vger.kernel.org, ming.lei@redhat.com,
dlemoal@kernel.org, hare@suse.de, axboe@kernel.dk,
gjoyce@ibm.com
Subject: Re: [PATCHv3 4/7] block: Introduce a dedicated lock for protecting queue elevator updates
Date: Tue, 25 Feb 2025 18:58:18 +0530 [thread overview]
Message-ID: <dd93c10c-d947-48f9-8e19-e7ea5b19eb3d@linux.ibm.com> (raw)
In-Reply-To: <20250224163356.GB5560@lst.de>
On 2/24/25 10:03 PM, Christoph Hellwig wrote:
> There's weird upper case for the first character after block. I know
> some subsystems like this, but in general try to at least be consistent
> for the series.
>
>> + /*
>> + * attributes which require some form of locking
>> + * other than q->sysfs_lock
>
> Make that a proper sentence:
>
> * Attributes which require some form of locking
> * other than q->sysfs_lock.
>
>> + /*
>> + * protects elevator switch/update
>> + */
>
> Also make this a full sentence, and mention which fields this protects.
>
> Otherwise looks good.
Okay, I'll incorporate above comments in the next patchset.
Thanks,
--Nilay
next prev parent reply other threads:[~2025-02-25 13:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 13:30 [PATCHv3 0/7] block: fix lock order and remove redundant locking Nilay Shroff
2025-02-24 13:30 ` [PATCHv3 1/7] block: acquire q->limits_lock while reading sysfs attributes Nilay Shroff
2025-02-25 7:38 ` Hannes Reinecke
2025-02-24 13:30 ` [PATCHv3 2/7] block: move q->sysfs_lock and queue-freeze under show/store method Nilay Shroff
2025-02-24 16:31 ` Christoph Hellwig
2025-02-25 7:41 ` Hannes Reinecke
2025-02-24 13:30 ` [PATCHv3 3/7] block: remove q->sysfs_lock for attributes which don't need it Nilay Shroff
2025-02-25 7:46 ` Hannes Reinecke
2025-02-24 13:30 ` [PATCHv3 4/7] block: Introduce a dedicated lock for protecting queue elevator updates Nilay Shroff
2025-02-24 16:33 ` Christoph Hellwig
2025-02-25 13:28 ` Nilay Shroff [this message]
2025-02-25 7:49 ` Hannes Reinecke
2025-02-24 13:30 ` [PATCHv3 5/7] block: protect nr_requests update using q->elevator_lock Nilay Shroff
2025-02-25 7:50 ` Hannes Reinecke
2025-02-24 13:30 ` [PATCHv3 6/7] block: protect wbt_lat_usec " Nilay Shroff
2025-02-25 7:53 ` Hannes Reinecke
2025-02-25 10:05 ` Nilay Shroff
2025-02-24 13:30 ` [PATCHv3 7/7] block: protect read_ahead_kb using q->limits_lock Nilay Shroff
2025-02-25 7:58 ` Hannes Reinecke
2025-02-25 10:18 ` Nilay Shroff
2025-02-25 11:43 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd93c10c-d947-48f9-8e19-e7ea5b19eb3d@linux.ibm.com \
--to=nilay@linux.ibm.com \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=gjoyce@ibm.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox