From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23DD3C4CEC9 for ; Tue, 17 Sep 2019 23:30:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3CFA21852 for ; Tue, 17 Sep 2019 23:30:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726196AbfIQXas (ORCPT ); Tue, 17 Sep 2019 19:30:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33080 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726131AbfIQXas (ORCPT ); Tue, 17 Sep 2019 19:30:48 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 20F2F10CC1EE; Tue, 17 Sep 2019 23:30:48 +0000 (UTC) Received: from [10.72.12.58] (ovpn-12-58.pek2.redhat.com [10.72.12.58]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4384B19C6A; Tue, 17 Sep 2019 23:30:45 +0000 (UTC) Subject: Re: [PATCH v3 0/2] blk-mq: Avoid memory reclaim when allocating To: Jens Axboe , josef@toxicpanda.com Cc: mchristi@redhat.com, hch@infradead.org, linux-block@vger.kernel.org References: <20190917120910.24842-1-xiubli@redhat.com> <426aa779-1011-5a75-bb73-ae573c229806@kernel.dk> <960dd93e-3e3f-b0f4-5be5-1f77639a1614@redhat.com> <380792f3-cc15-2dc2-e138-124976508978@kernel.dk> From: Xiubo Li Message-ID: Date: Wed, 18 Sep 2019 07:30:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <380792f3-cc15-2dc2-e138-124976508978@kernel.dk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.65]); Tue, 17 Sep 2019 23:30:48 +0000 (UTC) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 2019/9/18 7:25, Jens Axboe wrote: > On 9/17/19 5:19 PM, Xiubo Li wrote: >> On 2019/9/18 7:11, Jens Axboe wrote: >>> On 9/17/19 4:54 PM, Xiubo Li wrote: >>>> On 2019/9/17 22:13, Jens Axboe wrote: >>>>> On 9/17/19 6:09 AM, xiubli@redhat.com wrote: >>>>>> From: Xiubo Li >>>>>> >>>>>> Changed in V2: >>>>>> - Addressed the comment from Ming Lei, thanks. >>>>>> >>>>>> Changed in V3: >>>>>> - Switch to memalloc_noio_save/restore from Christoph's comment, thanks. >>>>> This now seems to be a mix of both approaches, which I don't think makes >>>>> sense at all. I think we should just stick to the gfp_t being passed in, >>>>> and defining the standard mask for init time blk-mq memory allocations. >>>>> >>>> Hmm, I might missed or misunderstand from the last thread. In this >>>> thread with the save/store, the GFP_KERNEL is using instead. Maybe >>>> save/store pair is not a exactly correct place or occasion to use here >>>> as @Bart mentioned. >>> Just make them all gfp based please, and skip the memalloc() stuff. >> Yeah, isn't the v2 thread needed here ? > It might be, I didn't look super closely at v2. I'll take a look. Sure :-) BRs