From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:52812 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751117AbeAPJ2u (ORCPT ); Tue, 16 Jan 2018 04:28:50 -0500 Subject: Re: [PATCH v3 11/13] bcache: add backing_request_endio() for bi_end_io of attached backing device I/O To: Coly Li , linux-bcache@vger.kernel.org Cc: linux-block@vger.kernel.org, Junhui Tang , Michael Lyle References: <20180114144236.28213-1-colyli@suse.de> <20180114144236.28213-12-colyli@suse.de> From: Hannes Reinecke Message-ID: Date: Tue, 16 Jan 2018 10:28:48 +0100 MIME-Version: 1.0 In-Reply-To: <20180114144236.28213-12-colyli@suse.de> Content-Type: text/plain; charset=utf-8 Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org On 01/14/2018 03:42 PM, Coly Li wrote: > In order to catch I/O error of backing device, a separate bi_end_io > call back is required. Then a per backing device counter can record I/O > errors number and retire the backing device if the counter reaches a > per backing device I/O error limit. > > This patch adds backing_request_endio() to bcache backing device I/O code > path, this is a preparation for further complicated backing device failure > handling. So far there is no real code logic change, I make this change a > separate patch to make sure it is stable and reliable for further work. > > Signed-off-by: Coly Li > Cc: Junhui Tang > Cc: Michael Lyle > --- > drivers/md/bcache/request.c | 95 +++++++++++++++++++++++++++++++++++-------- > drivers/md/bcache/super.c | 1 + > drivers/md/bcache/writeback.c | 1 + > 3 files changed, 81 insertions(+), 16 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)