Re: [PATCH] badblocks: Fix a nonsense WARN_ON() which checks whether a u64 variable < 0

Jens Axboe
2025-03-10T13:49:04Z

On 3/10/25 7:44 AM, Coly Li wrote:
>
>
>> 2025?3?10? 21:42?Jens Axboe <axboe@kernel.dk> ???
>>
>> On 3/9/25 10:12 AM, Coly Li wrote:
>>> Hi Jens,
>>>
>>> Could you please take a look at it and pick this patch into the for-6.15/block branch? The patch is generated based on the for-6.15/block branch.
>>
>> Just a heads-up - you don't need to send these emails outside of
>> just sending the patch, I do get the patches. If I didn't, then that'd
>> be a problem. If you feel patches need extra context, then just do a
>> cover letter for them.
>
> So if you are the receiver of the patch email, then I don?t need to
> worry that you will treat it as a normal patch for review. Can I take
> this as a rule?

Yes of course - I don't think I've ever seen anyone else send out a
patch with a followup a few minutes later to apply it. Just send out the
patch, and it should get applied. If it doesn't after a week or
whatever, then feel free to send a reminder. But a reminder to apply it
a few min after the original patch is a bit unusual and odd.

--
Jens Axboe