From: Jens Axboe <axboe@kernel.dk>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>, linux-block@vger.kernel.org
Subject: Re: [patch] block: clarify documentation for blk_{start|finish}_plug
Date: Tue, 8 Jan 2019 20:50:47 -0700 [thread overview]
Message-ID: <de3d3d0a-4d44-bb1b-133b-feabb281e467@kernel.dk> (raw)
In-Reply-To: <x49a7ka7qy9.fsf@segfault.boston.devel.redhat.com>
On 1/8/19 2:57 PM, Jeff Moyer wrote:
> There was some confusion about what these functions did. Make it clear
> that this is a hint for upper layers to pass to the block layer, and
> that it does not guarantee that I/O will not be submitted between a
> start and finish plug.
Thanks Jeff, that's definitely an improvement, I like how it's phrased
as intent, there are no guarantees and we can change things down the
line as well (the auto-unplug threshold is a good example of that).
Applied for 5.0.
--
Jens Axboe
prev parent reply other threads:[~2019-01-09 3:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 21:57 [patch] block: clarify documentation for blk_{start|finish}_plug Jeff Moyer
2019-01-08 22:09 ` Darrick J. Wong
2019-01-09 3:07 ` Ming Lei
2019-01-09 3:50 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de3d3d0a-4d44-bb1b-133b-feabb281e467@kernel.dk \
--to=axboe@kernel.dk \
--cc=darrick.wong@oracle.com \
--cc=jmoyer@redhat.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox