From: Jens Axboe <axboe@kernel.dk>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
linux-block@vger.kernel.org
Cc: Jan Kara <jack@suse.cz>, Ming Lei <ming.lei@redhat.com>,
Damien Le Moal <Damien.LeMoal@wdc.com>
Subject: Re: [PATCH 0/2] block: Fix stale page cache of discard or zero out ioctl
Date: Tue, 9 Nov 2021 07:33:02 -0700 [thread overview]
Message-ID: <de540f73-a512-0ac4-c822-d84ab931957d@kernel.dk> (raw)
In-Reply-To: <20211109104723.835533-1-shinichiro.kawasaki@wdc.com>
On 11/9/21 3:47 AM, Shin'ichiro Kawasaki wrote:
> When BLKDISCARD or BLKZEROOUT ioctl race with data read, stale page cache is
> left. This patch series have two fox patches for the stale page cache. Same
> fix approach was used as blkdev_fallocate() [1].
>
> [1] https://marc.info/?l=linux-block&m=163236463716836
>
> Shin'ichiro Kawasaki (2):
> block: Hold invalidate_lock in BLKDISCARD ioctl
> block: Hold invalidate_lock in BLKZEROOUT ioctl
>
> block/ioctl.c | 24 ++++++++++++++++++------
> 1 file changed, 18 insertions(+), 6 deletions(-)
>
Do you want to do a v2 with BLKRESETZONE added as well? I can do these
separately. but a bit awkward right now as my main block 5.16 branch
doesn't yet have the bdev size changes. I'll queue this up post flushing
out the remaining block bits for 5.16, if v2 with BLKRESETZONE happens
before that I'll just use that one.
--
Jens Axboe
next prev parent reply other threads:[~2021-11-09 14:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 10:47 [PATCH 0/2] block: Fix stale page cache of discard or zero out ioctl Shin'ichiro Kawasaki
2021-11-09 10:47 ` [PATCH 1/2] block: Hold invalidate_lock in BLKDISCARD ioctl Shin'ichiro Kawasaki
2021-11-09 11:59 ` Jan Kara
2021-11-09 10:47 ` [PATCH 2/2] block: Hold invalidate_lock in BLKZEROOUT ioctl Shin'ichiro Kawasaki
2021-11-09 11:59 ` Jan Kara
2021-11-09 11:07 ` [PATCH 0/2] block: Fix stale page cache of discard or zero out ioctl Ming Lei
2021-11-09 11:59 ` Jan Kara
2021-11-09 12:49 ` Shinichiro Kawasaki
2021-11-09 14:33 ` Jens Axboe [this message]
2021-11-10 1:13 ` Shinichiro Kawasaki
2021-11-09 17:11 ` Jens Axboe
2021-11-10 6:37 ` Chaitanya Kulkarni
2021-11-10 6:47 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de540f73-a512-0ac4-c822-d84ab931957d@kernel.dk \
--to=axboe@kernel.dk \
--cc=Damien.LeMoal@wdc.com \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox