From: Alexey Dobriyan <adobriyan@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [PATCH] uapi: add EROBLK
Date: Tue, 19 Nov 2024 20:20:33 +0300 [thread overview]
Message-ID: <dee8868f-45fa-40d7-bcaf-a46bf768e400@p183> (raw)
In-Reply-To: <Zzy7MGyTp9yw1ntQ@infradead.org>
On Tue, Nov 19, 2024 at 08:22:08AM -0800, Christoph Hellwig wrote:
> On Tue, Nov 19, 2024 at 06:54:52PM +0300, Alexey Dobriyan wrote:
> > Block drivers and DM sometimes use EROFS to report errors. There is
> > no confusion about what happens but naive error reporting code might
> > pass -EROFS to strerror(3) which will print "filesystem" when clearly
> > there is no filesystem anywhere, it is layer above.
> >
> > Or in other words, if EROFS exists, why not EROBLK?
> > It is not like there is a tax on errno values.
>
> And where would you return this value without breaking existing
> userspace?
New code may start returning it right away.
Old code may start checking for both and in ~100 years delete EROFS
clause.
next prev parent reply other threads:[~2024-11-19 17:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 15:54 [PATCH] uapi: add EROBLK Alexey Dobriyan
2024-11-19 16:22 ` Christoph Hellwig
2024-11-19 17:20 ` Alexey Dobriyan [this message]
2024-11-19 17:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dee8868f-45fa-40d7-bcaf-a46bf768e400@p183 \
--to=adobriyan@gmail.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox